Skip to content

Consider relaxing the Sampler.parameters API #438

Open
@arcondello

Description

@arcondello

Application
At the moment, the Sampler ABC asks that the Sampler.parameters attribute be a dict of the form {kwarg: [relevant_property, ...], ...}. In practice though we rarely use the relevant properties list and almost all samplers look like {'beta_range': [], 'num_reads': []}

Proposed Solution
I propose that Sampler.parameters should return a Collection of accepted sampler arguments. This supports our current form but the above example could instead be {'beta_range', 'num_reads'}.

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionQuestion or general discussion

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions