Upgrade from aws-sdk (v2) to @aws-sdk/client-lambda (v3) #85

Author: nelsonic

dpl.js

@@ -6,7 +6,7 @@ const dpl = require('./lib/index.js');
 const pkg = require(dpl.utils.getBasepath() + 'package.json');
 dpl.copyfiles(); // copy required files & dirs
 if (pkg.files_to_deploy.indexOf('.env') > -1) {
-  dpl.utils.makeEnvFile(); // github.com/numo-labs/aws-lambda-deploy/issues/31
+  dpl.utils.makeEnvFile();
 }
 dpl.install_node_modules(); // install only production node_modules
 dpl.zip(); // zip the /dist directory

lib/upload.js

@@ -1,7 +1,7 @@
 'use strict';
-const AWS = require('aws-sdk');
-AWS.config.region = process.env.AWS_REGION; // set your Environment Variables...
-const lambda = new AWS.Lambda();
+const AWS = require("@aws-sdk/client-lambda");
+const lambda = new AWS.Lambda({ region: process.env.AWS_REGION });
+
 const fs = require('fs'); // so we can read the zip file
 const assert = require('assert');
 const utils = require('../lib/utils');
@@ -22,20 +22,15 @@ module.exports = function upload (pkg, callback) {
     pkg = PKG
   }
   const FUNCTION_NAME = utils.functionName(pkg);
-  // try {
-    lambda.getFunction({ FunctionName: FUNCTION_NAME }, function (err, data) {
-      /* istanbul ignore else  */
-      if (err) { // if the function does not already exist we create it.
-        console.error('upload lambda.getFunction error:', err);
-        return lambda.createFunction(createParams(pkg), callback);
-      } else { // otherwise update the *existing* lambda function:
-        return updateFunction(pkg, callback);
-      }
-    });
-  // } catch (error) {
-  //   console.error(error);
-  //   return callback()
-  // }
+  lambda.getFunction({ FunctionName: FUNCTION_NAME }, function (err, data) {
+    /* istanbul ignore else  */
+    if (err) { // if the function does not already exist we create it.
+      console.error('upload lambda.getFunction error:', err);
+      return lambda.createFunction(createParams(pkg), callback);
+    } else { // otherwise update the *existing* lambda function:
+      return updateFunction(pkg, callback);
+    }
+  });
 };
 
 function createParams (pkg) {

package-lock.json

@@ -71,7 +71,7 @@
     "tape": "^4.13.2"
   },
   "dependencies": {
-    "aws-sdk": "^2.1550.0",
+    "@aws-sdk/client-lambda": "^3.504.0",
     "env2": "^2.2.2"
   },
   "semistandard": {

package.json

@@ -9,9 +9,8 @@ const PKG = require(basepath + 'package.json');
 const FUNCTION_NAME = utils.functionName(PKG);
 console.log('FUNCTION_NAME:', FUNCTION_NAME);
 
-const AWS = require('aws-sdk');
-AWS.config.region = process.env.AWS_REGION; // set your Environment Variables...
-const lambda = new AWS.Lambda();
+const AWS = require("@aws-sdk/client-lambda");
+const lambda = new AWS.Lambda({ region: process.env.AWS_REGION });
 // console.log(' - - - - - - - - - - - - - - - - - - - - - - ');
 // console.log(process);
 // console.log(' - - - - - - - - - - - - - - - - - - - - - - ');

test/000_debug.test.js

@@ -9,9 +9,9 @@ test('install production node_modules only', async function (t) {
   const distpath = path.normalize(process.env.TMPDIR + 'dist/');
   copyfiles();
   installnodemodules();
-  const awspkg = path.resolve(distpath, 'node_modules/aws-sdk/package.json');
+  const awspkg = path.resolve(distpath, 'node_modules/@aws-sdk/client-lambda/package.json');
   const pkg = require(awspkg);
-  t.deepEqual(pkg.name, 'aws-sdk');
+  t.deepEqual(pkg.name, '@aws-sdk/client-lambda');
   utils.deleteDirContents(distpath, true); // cleanup for next test
   t.end();
 });

test/03_install_node_modules.test.js

@@ -8,9 +8,9 @@ const utils = require('../lib/utils');
 const fs = require('fs');
 const path = require('path');
 
-const AWS = require('aws-sdk');
-AWS.config.region = process.env.AWS_REGION; // set your Environment Variables...
-const lambda = new AWS.Lambda();
+const AWS = require("@aws-sdk/client-lambda");
+const lambda = new AWS.Lambda({ region: process.env.AWS_REGION });
+
 const basepath = utils.getBasepath();
 const PKG = require(basepath + 'package.json');
 const FUNCTION_NAME = utils.functionName(PKG);

test/05_upload.test.js

@@ -10,9 +10,8 @@ const upload = require('../lib/upload');
 const utils = require('../lib/utils');
 
 const basepath = utils.getBasepath();
-const AWS = require('aws-sdk');
-AWS.config.region = process.env.AWS_REGION; // set your Environment Variables...
-const lambda = new AWS.Lambda();
+const AWS = require("@aws-sdk/client-lambda");
+const lambda = new AWS.Lambda({ region: process.env.AWS_REGION });
 let pkg = require(path.resolve(basepath, 'package.json'));
 const FUNCTION_NAME = utils.functionName(pkg);