[DQL] Fixing code reviews

Author: dorian-krefft-dt

CHANGELOG.md

@@ -11,6 +11,7 @@
   - Adding predefined timeframes to the DQL execution toolbar (user can still define a custom one)
   - The DQL execution result will show an empty cell for a boolean column that had a `null` value (instead of the
     unchecked checkbox). This change helps to differentiate between `false` and `null` values.
+  - Executed DQL queries will now be grouped by the tenant they were executed on in the Services tab
 - The "Show DQL query" option when executing DQL will now try to show the parsed query instead of the raw one, if
   possible.
 - Adding support for "Expression DQL" file (with `.edql` extensions), which allows to define a DQL expression without

src/main/java/pl/thedeem/intellij/common/Icons.java

@@ -1,10 +1,9 @@
 package pl.thedeem.intellij.common;
 
 import com.intellij.openapi.util.IconLoader;
-import pl.thedeem.intellij.dql.DQLIcon;
 
 import javax.swing.*;
 
 public interface Icons {
-    Icon DYNATRACE_LOGO = IconLoader.getIcon("/icons/dynatrace.png", DQLIcon.class);
+    Icon DYNATRACE_LOGO = IconLoader.getIcon("/icons/dynatrace.png", Icons.class);
 }

src/main/java/pl/thedeem/intellij/dql/definition/model/QueryConfiguration.java

@@ -115,7 +115,7 @@ public QueryConfiguration copy() {
         copy.setTimeframeEnd(this.timeframeEnd);
         copy.setRunConfigName(this.runConfigName);
         copy.setOriginalFile(this.originalFile);
-        copy.setDefinedVariables(this.definedVariables);
+        copy.setDefinedVariables(List.copyOf(this.definedVariables));
         return copy;
     }
 }

src/main/java/pl/thedeem/intellij/dql/editor/actions/QueryConfigurationOptionsAction.java

@@ -71,7 +71,7 @@ public void updateCustomComponent(@NotNull JComponent component, @NotNull Presen
             }
             if (!myQueryConfigurationComponent.maxBytes().isFocusOwner()
                     && !Objects.equals(parseLong(myQueryConfigurationComponent.maxBytes().getText()), config.maxResultBytes())) {
-                myQueryConfigurationComponent.maxBytes().setText(String.valueOf(config.maxResultRecords()));
+                myQueryConfigurationComponent.maxBytes().setText(String.valueOf(config.maxResultBytes()));
             }
             if (!myQueryConfigurationComponent.maxRecords().isFocusOwner()
                     && !Objects.equals(parseLong(myQueryConfigurationComponent.maxRecords().getText()), config.maxResultRecords())) {

src/main/resources/messages/DQLBundle.properties

@@ -402,7 +402,7 @@ intention.joinFilterCommands=Join surrounding filtering commands
 intention.replaceAliasWithAssignExpression=Replace alias with assign expression
 intention.splitFilterCommands=Split filtering command
 services.executeDQL.serviceName={0}
-services.executeDQL.cancelRequested=The query "{0}" has been requested for cancellation.
+services.executeDQL.cancelRequested=The query with ID "{0}" has been requested for cancellation.
 services.executeDQL.errors.missingTenant=An invalid Dynatrace tenant "{0}" was used for the execution
 services.executeDQL.errors.invalidPayload=Could not create a valid request to execute the DQL query
 services.executeDQL.selectQuery.title=Select DQL Query To Execute