Skip to content

Commit 369e2da

Browse files
Fixing code review issue
1 parent ac18a42 commit 369e2da

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

src/main/java/pl/thedeem/intellij/dql/editor/actions/QueryConfigurationAction.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ public void update(@NotNull AnActionEvent e) {
3636

3737
@Override
3838
public void actionPerformed(@NotNull AnActionEvent e) {
39+
saveCurrentQueryConfiguration(e);
40+
}
41+
42+
protected void saveCurrentQueryConfiguration(@NotNull AnActionEvent e) {
3943
PsiFile file = e.getData(CommonDataKeys.PSI_FILE);
4044
QueryConfiguration configuration = e.getData(DQLQueryConfigurationService.DATA_QUERY_CONFIGURATION);
4145
if (configuration != null && file != null) {
@@ -54,7 +58,7 @@ public void actionPerformed(@NotNull AnActionEvent e) {
5458
@Override
5559
protected void updateSelectedTenant(@NotNull String selectedTenant, @NotNull AnActionEvent e) {
5660
super.updateSelectedTenant(selectedTenant, e);
57-
QueryConfigurationAction.this.actionPerformed(e);
61+
saveCurrentQueryConfiguration(e);
5862
}
5963

6064
@Override
@@ -80,7 +84,7 @@ public void update(@NotNull AnActionEvent e) {
8084
@Override
8185
public void actionPerformed(@NotNull AnActionEvent e) {
8286
super.actionPerformed(e);
83-
QueryConfigurationAction.this.actionPerformed(e);
87+
saveCurrentQueryConfiguration(e);
8488
}
8589
});
8690
group.addAction(new QueryConfigurationOptionsAction() {
@@ -93,7 +97,7 @@ public void update(@NotNull AnActionEvent e) {
9397
@Override
9498
public void actionPerformed(@NotNull AnActionEvent e) {
9599
super.actionPerformed(e);
96-
QueryConfigurationAction.this.actionPerformed(e);
100+
saveCurrentQueryConfiguration(e);
97101
}
98102
});
99103
group.add(new SaveQueryConfigurationAction() {

src/main/java/pl/thedeem/intellij/dql/exec/panel/DQLQueryConsolePanel.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ public DQLQueryConsolePanel(@NotNull Project project, @NotNull String content, @
4747
group.setInjectedContext(true);
4848
group.add(new QueryConfigurationAction() {
4949
@Override
50-
public void actionPerformed(@NotNull AnActionEvent e) {
50+
protected void saveCurrentQueryConfiguration(@NotNull AnActionEvent e) {
51+
// do nothing - console is in-memory only, no save needed
5152
}
5253
});
5354

0 commit comments

Comments
 (0)