Fixed #634

Author: Reinhard-Pilz-Dynatrace

dynatrace/api/builtin/deployment/oneagent/defaultversion/service.go

@@ -18,14 +18,43 @@
 package defaultversion
 
 import (
+	"context"
+
+	"github.com/dynatrace-oss/terraform-provider-dynatrace/dynatrace/api"
 	defaultversion "github.com/dynatrace-oss/terraform-provider-dynatrace/dynatrace/api/builtin/deployment/oneagent/defaultversion/settings"
 	"github.com/dynatrace-oss/terraform-provider-dynatrace/dynatrace/settings"
-	"github.com/dynatrace-oss/terraform-provider-dynatrace/dynatrace/settings/services/settings20"
+	"github.com/google/uuid"
 )
 
 const SchemaVersion = "1.0.2"
 const SchemaID = "builtin:deployment.oneagent.default-version"
 
 func Service(credentials *settings.Credentials) settings.CRUDService[*defaultversion.Settings] {
-	return settings20.Service[*defaultversion.Settings](credentials, SchemaID, SchemaVersion)
+	return &service{}
+}
+
+type service struct{}
+
+func (me *service) List(ctx context.Context) (api.Stubs, error) {
+	return api.Stubs{}, nil
+}
+
+func (me *service) Get(ctx context.Context, id string, v *defaultversion.Settings) error {
+	return nil
+}
+
+func (me *service) SchemaID() string {
+	return SchemaID
+}
+
+func (me *service) Create(ctx context.Context, v *defaultversion.Settings) (*api.Stub, error) {
+	return &api.Stub{ID: uuid.NewString()}, nil
+}
+
+func (me *service) Update(ctx context.Context, id string, v *defaultversion.Settings) error {
+	return nil
+}
+
+func (me *service) Delete(ctx context.Context, id string) error {
+	return nil
 }

dynatrace/api/builtin/deployment/oneagent/defaultversion/settings/settings.go

@@ -18,11 +18,8 @@
 package defaultversion
 
 import (
-	"fmt"
-
 	"github.com/dynatrace-oss/terraform-provider-dynatrace/terraform/hcl"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
-	"golang.org/x/exp/slices"
 )
 
 type Settings struct {
@@ -37,14 +34,18 @@ func (me *Settings) Name() string {
 func (me *Settings) Schema() map[string]*schema.Schema {
 	return map[string]*schema.Schema{
 		"default_version": {
-			Type:        schema.TypeString,
-			Description: "Default version",
-			Required:    true,
+			Type:             schema.TypeString,
+			Description:      "Default version",
+			Required:         true,
+			StateFunc:        func(i any) string { return "" },
+			DiffSuppressFunc: func(k, oldValue, newValue string, d *schema.ResourceData) bool { return true },
 		},
 		"revision": {
-			Type:        schema.TypeString,
-			Description: "Revision",
-			Optional:    true, // precondition
+			Type:             schema.TypeString,
+			Description:      "Revision",
+			Optional:         true, // precondition
+			StateFunc:        func(i any) string { return "" },
+			DiffSuppressFunc: func(k, oldValue, newValue string, d *schema.ResourceData) bool { return true },
 		},
 	}
 }
@@ -56,13 +57,6 @@ func (me *Settings) MarshalHCL(properties hcl.Properties) error {
 	})
 }
 
-func (me *Settings) HandlePreconditions() error {
-	if me.Revision == nil && !slices.Contains([]string{"latest"}, string(me.DefaultVersion)) {
-		return fmt.Errorf("'revision' must be specified if 'default_version' is not set to '%v'", me.DefaultVersion)
-	}
-	return nil
-}
-
 func (me *Settings) UnmarshalHCL(decoder hcl.Decoder) error {
 	return decoder.DecodeAll(map[string]any{
 		"default_version": &me.DefaultVersion,

templates/resources/oneagent_default_version.md.tmpl

@@ -1,30 +1,7 @@
 ---
 layout: ""
 page_title: dynatrace_oneagent_default_version Resource - terraform-provider-dynatrace"
-subcategory: "Environment Settings"
+subcategory: "Deprecated"
 description: |-
-  The resource `dynatrace_oneagent_default_version` covers configuration for OneAgent default version
----
-
-# dynatrace_oneagent_default_version (Resource)
-
--> This resource requires the API token scopes **Read settings** (`settings.read`) and **Write settings** (`settings.write`)
-
-## Dynatrace Documentation
-
-- OneAgent update - https://www.dynatrace.com/support/help/setup-and-configuration/dynatrace-oneagent/oneagent-update
-
-- Settings API - https://www.dynatrace.com/support/help/dynatrace-api/environment-api/settings (schemaId: `builtin:deployment.oneagent.default-version`)
-
-## Export Example Usage
-
-- `terraform-provider-dynatrace -export dynatrace_oneagent_default_version` downloads existing OneAgent default version configuration
-
-The full documentation of the export feature is available [here](https://dt-url.net/h203qmc).
-
-## Resource Example Usage
-
-{{ tffile "dynatrace/api/builtin/deployment/oneagent/defaultversion/testdata/terraform/example_a.tf" }}
-
-{{ .SchemaMarkdown | trimspace }}
- 
+    The resource `dynatrace_oneagent_default_version` just exists for backwards compatibility. The settings it addresses are no longer configurable. The resource `dynatrace_oneagent_updates` covers this functionality now.
+---