Skip to content

Commit 5dff932

Browse files
committed
fix(js): use includes instead of startsWith for hash error log checks
The deprecation warning added by api_hash.c now appears before the actual error message in the logs, so startsWith() assertions fail. Change to includes() which is order-independent.
1 parent fb61ba9 commit 5dff932

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

bindings/javascript/src/index.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ test("Unknown hash type", async (t) => {
224224
try {
225225
await zenroom_hash_init("invalidhash");
226226
} catch (e) {
227-
t.true(e.logs.startsWith("zenroom_hash_init :: invalid hash type: invalidhash\n"), e.logs);
227+
t.true(e.logs.includes("zenroom_hash_init :: invalid hash type: invalidhash"), e.logs);
228228
t.true(e.logs.includes(LEGACY_HASH_API_WARNING), e.logs);
229229
}
230230
});
@@ -236,7 +236,7 @@ test("Wrong context prefix (update)", async (t) => {
236236
"518985977ee21d2bf622a20567124fcbf11c72df805365835ab3c041f4a9cd8a0ad63c9dee1018aa21a9fa3720f47dc48006"
237237
);
238238
} catch (e) {
239-
t.true(e.logs.startsWith("zenroom_hash_update :: invalid hash context prefix\n"), e.logs);
239+
t.true(e.logs.includes("zenroom_hash_update :: invalid hash context prefix"), e.logs);
240240
t.true(e.logs.includes(LEGACY_HASH_API_WARNING), e.logs);
241241
}
242242
});
@@ -246,7 +246,7 @@ test("Wrong context prefix (final)", async (t) => {
246246
const res = await zenroom_hash_final("z");
247247
t.fail("zenroom_hash_final should fail"+JSON.stringify(res));
248248
} catch (e) {
249-
t.true(e.logs.startsWith("zenroom_hash_final :: invalid hash context prefix\n"), e.logs);
249+
t.true(e.logs.includes("zenroom_hash_final :: invalid hash context prefix"), e.logs);
250250
t.true(e.logs.includes(LEGACY_HASH_API_WARNING), e.logs);
251251
}
252252
});
@@ -259,7 +259,7 @@ test("Use zenroom_hash with unknown hash function", async (t) => {
259259
);
260260
console.log(res)
261261
} catch (e) {
262-
t.true(e.logs.startsWith("zenroom_hash_init :: invalid hash type: z\n"), e.logs);
262+
t.true(e.logs.includes("zenroom_hash_init :: invalid hash type: z"), e.logs);
263263
t.true(e.logs.includes(LEGACY_HASH_API_WARNING), e.logs);
264264
}
265265
});

0 commit comments

Comments
 (0)