Version in pkg-config file is not reflecting the actual version

[tgurr]

frei0r.pc of e.g. 3.0.0:

prefix=/usr/x86_64-pc-linux-gnu
exec_prefix=/usr/x86_64-pc-linux-gnu
libdir=/usr/x86_64-pc-linux-gnu/lib
includedir=/usr/x86_64-pc-linux-gnu/include

Name: frei0r
Description: minimalistic plugin API for video effects
Version: 2.5.1
Libs:
Cflags: -I${includedir}

probably due to https://github.com/dyne/frei0r/blob/master/CMakeLists.txt#L6 never being updated accordingly.

[jaromil]

@matteo-cristino as you are the versioning master, any easy fix to align pkg-config with semver automatically comes to mind?
Also I am afraid we will need to roll out 3.0.1 for this

[matteo-cristino]

I think that instead of setting an hadcoded value we should read the latest git tag, I am not an expert in cmake, but I can do some research in the next days, I think it is feasible

[tgurr]

With 3.0.1 now still hard-coding a "default" version (FREI0R_VERSION "3.0.0") https://github.com/dyne/frei0r/blob/v3.0.1/CMakeLists.txt#L5 packagers are now required to manually set and pass a version value manually, else they end up with the pkg-config file of 3.0.1 stating 3.0.0.

prefix=/usr/x86_64-pc-linux-gnu
exec_prefix=/usr/x86_64-pc-linux-gnu
libdir=/usr/x86_64-pc-linux-gnu/lib
includedir=/usr/x86_64-pc-linux-gnu/include

Name: frei0r
Description: minimalistic plugin API for video effects
Version: 3.0.0
Libs:
Cflags: -I${includedir}

While it is now at least possible to influence the set version (thanks!) it's imho not a very common practice to manually have to pass a/the version to CMake.

[jaromil]

Good point, it works for CI builds but versioning should also be updated in the released sources.

[rrrapha]

Requiring git at build time is a bad idea for portability and packaging. To be honest, I think it's best to manually adjust the VERSION in CMakeLists.txt before tagging a release.

[jaromil]

I really wanted to automate everything, but considering a glitch just had on 3.1.0 tagged but not released and picked up by some distros.... I think you may have yet another good point. If we make it manual however, releases will be less.

[matteo-cristino]

If you want I think I can automate the commit of the new version on tag creation using semantic release