Skip to content

Commit 9e5fa82

Browse files
hadleyrcannood
andauthored
Fix for upcoming purrr release (#166)
* Fix partial match warning * Replace `invoke()` with `exec()` * add entry to news * add minimal version --------- Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
1 parent 8525356 commit 9e5fa82

4 files changed

Lines changed: 13 additions & 9 deletions

File tree

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Imports:
4343
magrittr,
4444
Matrix,
4545
methods,
46-
purrr,
46+
purrr (>= 1.0.0),
4747
processx,
4848
readr,
4949
stringr,

NEWS.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# dynwrap 1.2.5
2+
3+
* BUG FIX `convert_definition()`: Fix for purrr having deprecated `invoke` in favour of `exec` (PR #166).
4+
15
# dynwrap 1.2.4
26

37
* Resubmission after babelwhale was removed from CRAN.

R/method_process_definition.R

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -320,12 +320,12 @@ is_ti_method <- function(method) {
320320
#' @export
321321
convert_definition <- function(definition_raw) {
322322
definition(
323-
method = purrr::invoke(def_method, definition_raw$method %||% list()),
324-
wrapper = purrr::invoke(def_wrapper, definition_raw$wrapper %||% list()),
325-
container = purrr::invoke(def_container, definition_raw$container %||% list()),
326-
package = purrr::invoke(def_package, definition_raw$package %||% list()),
327-
manuscript = purrr::invoke(def_manuscript, definition_raw$manuscript %||% list()),
328-
parameters = dynparam::as_parameter_set(definition_raw$parameters %||% list())
323+
method = purrr::exec(def_method, !!!definition_raw$method),
324+
wrapper = purrr::exec(def_wrapper, !!!definition_raw$wrapper),
325+
container = purrr::exec(def_container, !!!definition_raw$container),
326+
package = purrr::exec(def_package, !!!definition_raw$package),
327+
manuscript = purrr::exec(def_manuscript, !!!definition_raw$manuscript),
328+
parameters = dynparam::as_parameter_set(definition_raw$parameters)
329329
)
330330
}
331331

R/wrap_add_dimred.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ add_dimred <- function(
5858
if (is.matrix(dimred) || is.data.frame(dimred)) {
5959
dimred <- process_dimred(dataset, dimred)
6060
assert_that(
61-
rownames(dimred) %all_in% dataset$cell_id,
62-
dataset$cell_id %all_in% rownames(dimred)
61+
rownames(dimred) %all_in% dataset$cell_ids,
62+
dataset$cell_ids %all_in% rownames(dimred)
6363
)
6464

6565
} else {

0 commit comments

Comments
 (0)