⬆️ Track upgrade to cordova android@9.0.0 and ios@6.0.1

[shankari]

This bug is a follow on to #519, tracking the upgrade to the even more recent versions of cordova.

[shankari]

There are a few plugins that don't install correctly:

• phonegap-plugin-push because of dependency cordova-support-google-services@1.3.1
• cordova-plugin-x-socialsharing; because of dependency es6-promise-plugin@4.2.2
• cordova-plugin-local-notification because of dependency cordova-plugin-badge@0.8.8
• all of our plugins, because of invalid format

[shankari]

Let's first fix our plugins, so that we know what the correct format should look like

[shankari]

There is also a workaround:

We can first install the "broken" plugin using npm directly, which works:

$ npm install cordova-plugin-badge@0.8.8
npm WARN edu.berkeley.eecs.emission@2.8.1 No repository field.
npm WARN edu.berkeley.eecs.emission@2.8.1 No license field.

+ cordova-plugin-badge@0.8.8
added 1 package from 1 contributor, removed 1 package and audited 1706 packages in 11.249s

47 packages are looking for funding
  run `npm fund` for details

found 173 vulnerabilities (45 low, 75 moderate, 53 high)
  run `npm audit fix` to fix them, or `npm audit` for details

And then if we try to install the dependent plugin, it finds the "fetched" plugin and installs it.

$ npx cordova plugin add cordova-plugin-local-notification
Installing "cordova-plugin-local-notification" for android
android-sdk version check failed (/Users/kshankar/e-mission/upgrade_platform/platforms/android/cordova/android_sdk_version), continuing anyways.
Plugin dependency "cordova-plugin-device@2.0.3" already fetched, using that version.
Dependent plugin "cordova-plugin-device" already installed on android.
Installing "cordova-plugin-badge" for android
Subproject Path: CordovaLib
Subproject Path: app
Subproject Path: CordovaLib
Subproject Path: app
Installing "cordova-plugin-local-notification" for ios
Plugin dependency "cordova-plugin-device@2.0.3" already fetched, using that version.
Dependent plugin "cordova-plugin-device" already installed on ios.
Plugin dependency "cordova-plugin-badge@0.8.8" already fetched, using that version.
Installing "cordova-plugin-badge" for ios
Adding cordova-plugin-local-notification to package.json

$ npx cordova plugin list | grep notification
cordova-plugin-local-notification 0.9.0-beta.2 "LocalNotification"

[shankari]

For the non-emission plugins, they don't list their dependencies in package.json. This means that when we use npm install, their dependencies are not fetched, and they can't be installed. However, the dependencies are listed in their plugin.xml, so when we run npx cordova prepare, they are retrieved. A second npx cordova prepare successfully installs them.

$ npm install

> fsevents@1.2.13 install /Users/kshankar/e-mission/upgrade_platform/node_modules/fsevents
> node install.js

added 1707 packages from 1157 contributors and audited 1707 packages in 25.55s

47 packages are looking for funding
  run `npm fund` for details

found 173 vulnerabilities (45 low, 75 moderate, 53 high)
  run `npm audit fix` to fix them, or `npm audit` for details

$ ls -al node_modules/cordova-plugin-badge
ls: node_modules/cordova-plugin-badge: No such file or directory
$ ls -al node_modules/cordova-support-google-services
ls: node_modules/cordova-support-google-services: No such file or directory

$ npx cordova prepare
Failed to install 'phonegap-plugin-push': CordovaError: Failed to fetch plugin cordova-support-google-services@~1.3.1 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Could not determine package name from output:
cordova-support-google-services@1.3.2 node_modules/cordova-support-google-services
    at /Users/kshankar/e-mission/upgrade_platform/node_modules/cordova-lib/src/plugman/fetch.js:146:43
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
Failed to restore plugin "phonegap-plugin-push" from config.xml. You might need to try adding it again. Error: Failed to fetch plugin cordova-support-google-services@~1.3.1 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Could not determine package name from output:
cordova-support-google-services@1.3.2 node_modules/cordova-support-google-services
...
Failed to install 'cordova-plugin-x-socialsharing': CordovaError: Failed to fetch plugin es6-promise-plugin@^4.1.0 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Could not determine package name from output:
es6-promise-plugin@4.2.2 node_modules/es6-promise-plugin
    at /Users/kshankar/e-mission/upgrade_platform/node_modules/cordova-lib/src/plugman/fetch.js:146:43
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
Failed to restore plugin "cordova-plugin-x-socialsharing" from config.xml. You might need to try adding it again. Error: Failed to fetch plugin es6-promise-plugin@^4.1.0 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Could not determine package name from output:
es6-promise-plugin@4.2.2 node_modules/es6-promise-plugin
....
Failed to install 'cordova-plugin-local-notification': CordovaError: Failed to fetch plugin cordova-plugin-badge@>=0.8.5 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Could not determine package name from output:
cordova-plugin-badge@0.8.8 node_modules/cordova-plugin-badge
    at /Users/kshankar/e-mission/upgrade_platform/node_modules/cordova-lib/src/plugman/fetch.js:146:43
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
Failed to restore plugin "cordova-plugin-local-notification" from config.xml. You might need to try adding it again. Error: Failed to fetch plugin cordova-plugin-badge@>=0.8.5 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Could not determine package name from output:
cordova-plugin-badge@0.8.8 node_modules/cordova-plugin-badge
...
<emission plugin failures>

$ ls -al node_modules/cordova-plugin-badge
total 80
...
$ ls -al node_modules/cordova-support-google-services
total 40

$ npx cordova prepare
<emission plugin failures only>

$ npx cordova plugin list
...
cordova-plugin-local-notification 0.9.0-beta.2 "LocalNotification"
cordova-plugin-x-socialsharing 5.6.8 "SocialSharing"
phonegap-plugin-push 2.3.0 "PushPlugin"
...

[shankari]

For the e-mission plugins, there are two issues:

• the ID in plugin.xml and package.json are typically different. This seems to be bad, I think we should have changed both while creating the package.json; that is what cordova-plugin-device did (apache/cordova-plugin-device@b58b5ed), consistent with https://cordova.apache.org/announcements/2015/04/21/plugins-release-and-move-to-npm.html
• cordova@9.0.0 seems to have significant issues supporting plugin install from git or from local path. After spending many hours investigating this last night, I filed https://github.com/apache/cordova-lib/issues/845

[shankari]

Next steps:

• Downgrade to cordova@8.0.0 for now. Note that this is only the cordova scripts and is a devDependency. Changes to this will affect the build process but should not affect the resulting app significantly
• Fix all the e-mission plugins to have the correct name (should do it anyway)
• Edit the data collection plugin to use a wrapper class for the activities (Use a wrapper class for the activities as well e-mission-data-collection#80)
• Switch to the most recent version of google-play-services (we are using 11, current is 17)
• Switch to the most recent version of all plugins
• Fix local notification
  • cordova-plugin-local-notifications seems to have a bunch of important pending changes Android 10 updates katzer/cordova-plugin-local-notifications#1891 and potentially some others such as Fix for Samsung too many alarms issue. katzer/cordova-plugin-local-notifications#1873
  • or we could just switch to https://github.com/timkellypa/cordova-plugin-local-notifications instead.
  • after these merges, also fix Subtle bugs on both android and iOS e-mission-transition-notify#25
• Remove deprecated cordova-plugin-google-services
  • from phonegap-plugin-push, by merging [DRAFT] feat: remove cordova-support-google-services dependency phonegap/phonegap-plugin-push#2873

Depending on the responses to the cordova-lib bug, decide whether to upgrade to cordova@9.0.0 or not

• if the bug is not resolved, this will involve publishing our plugins
• but how will we deal with the private versions of the other plugins?

[shankari]

Ended up resolving https://github.com/apache/cordova-lib/issues/845 instead because I got sucked into it. The issue was with an old version of phonegap in the dependencies. Upgrading to a newer version of phonegap fixes everything in #554 (comment)

Our plugins still fail because of

Failed to install 'edu.berkeley.eecs.emission.cordova.usercache': CordovaError: Using "requireCordovaModule" to load non-cordova module "fs" is not supported. Instead, add this module to your dependencies and use regular "require" to load it.

So modified next steps:

• Switch to the most recent version of all plugins
• Fix our plugins
  • Edit the data collection plugin to use a wrapper class for the activities (Use a wrapper class for the activities as well e-mission-data-collection#80)
  • Change the hook for all of them as per the instructions above
  • Fix all the e-mission plugins to have the correct name (should do it anyway)
  • Switch to the most recent version of google-play-services (we are using 11, current is 17)
• Fix local notification (potentially upgrade to the android10 changes)
• (optional) create a private version of phonegap-plugin-push that doesn't depend on cordova-plugin-google-services

[shankari]

Switch to the most recent version of all plugins

Installed and ran cordova-plugin-update

It detected and applied the following updates

cordova-plugin-customurlscheme (4.3.0 => 5.0.1)
cordova-plugin-email-composer (0.8.15 => 0.9.2)
cordova-plugin-x-socialsharing (5.6.5 => 6.0.0)
cordova-plugin-inappbrowser (3.2.0 => 4.0.0)
cordova-plugin-local-notification (0.9.0-beta.2 => 0.9.0-beta.3)
cordova-plugin-advanced-http (2.5.1 => 3.0.0)
cordova-plugin-ionic-webview (4.2.1 => 5.0.0)

[shankari]

While comparing the changes, the newly added plugin had removed "OKHTTP_VERSION": "3.10.0" from cordova-plugin-advanced-http. If we start getting any weird crashes, might need to add that back.

[shankari]

After these upgrades, iOS compiles. Making the hook changes first so that we can get android to compile as well and start checking in partial updates.

[shankari]

Made hook changes and fixed all names. Was able to add all plugins.
Current status:

• iOS still compiles
• android fails with the error

> This project uses AndroidX dependencies, but the 'android.useAndroidX' property is not enabled. Set this property to true in the gradle.properties file and retry.

The only plugin that appears to currently use AndroidX is

$ grep -r androidx plugins/
plugins//cordova-plugin-x-socialsharing/plugin.xml:    <framework src="androidx.legacy:legacy-support-v4:1.0.0" />
plugins//cordova-plugin-x-socialsharing/src/android/nl/xservices/plugins/FileProvider.java:public class FileProvider extends androidx.core.content.FileProvider {

Downgrading it to 5.6.8, upgrading gradle version to 6.5 and retrying.

[shankari]

both android and iOS now compile successfully.

Current status:

• Fix local notification (potentially upgrade to the android10 changes)
• Switch to the most recent version of all plugins
• Fix our plugins
  • Edit the data collection plugin to use a wrapper class for the activities (Use a wrapper class for the activities as well e-mission-data-collection#80)
  • Change the hook for all of them as per the instructions above
  • Fix all the e-mission plugins to have the correct name (should do it anyway)
  • Switch to the most recent version of google-play-services (we are using 11, current is 17)

Next step: Edit the data collection plugin

[shankari]

Actually, next step: trying to run the app 😄

app runs fine in android, but basically hangs in iOS. This is really weird because it gets to

[Log] Finished changing state from {"url":"/splash","templateUrl":"templates/splash/splash.html","controller":"SplashCtrl","name":"splash"} to {"url":"/intro","templateUrl":"templates/intro/intro.html","controller":"IntroCtrl","name":"root.intro"} (cordova.js, line 1413)

But the intro template is not displayed. I should probably revert to the older version of the webview, ensure that it works and then roll forward.

[shankari]

ios combinations are below:

cordova-plugin-ionic-webview	cordova-ios	works?
4.2.1	5.1.1	✔️
5.0.0	5.1.1	✔️
4.2.1	6.1.0	❌
5.0.0	6.1.0	❌

So basically, the upgrade to cordova-ios@6.1.0 breaks ionic webview.

[shankari]

Created MCVE
https://github.com/shankari/ionic-webview-mcve
and filed related issue ionic-team/cordova-plugin-ionic-webview#594

Let's stay on cordova-ios@5.1.1 until this is resolved.

Now, next step is to edit the data collection plugin