add test for user bulk update

Author: Kakadus

evap/staff/tests/test_views.py

@@ -4,7 +4,7 @@
 from abc import ABC, abstractmethod
 from io import BytesIO
 from typing import Literal
-from unittest.mock import Mock, PropertyMock, patch
+from unittest.mock import MagicMock, Mock, PropertyMock, patch
 
 import openpyxl
 import xlrd
@@ -423,11 +423,11 @@ class TestUserBulkUpdateView(WebTestStaffMode):
     filename = os.path.join(settings.BASE_DIR, "staff/fixtures/test_user_bulk_update_file.txt")
 
     @classmethod
-    def setUpTestData(cls):
+    def setUpTestData(cls) -> None:
         cls.random_excel_file_content = excel_data.random_file_content
         cls.manager = make_manager()
 
-    def test_testrun_deletes_no_users(self):
+    def test_testrun_deletes_no_users(self) -> None:
         page = self.app.get(self.url, user=self.manager)
         form = page.forms["user-bulk-update-form"]
 
@@ -443,7 +443,7 @@ def test_testrun_deletes_no_users(self):
         helper_delete_all_import_files(self.manager.id)
 
     @override_settings(INSTITUTION_EMAIL_DOMAINS=["institution.example.com", "internal.example.com"])
-    def test_multiple_email_matches_trigger_error(self):
+    def test_multiple_email_matches_trigger_error(self) -> None:
         baker.make(UserProfile, email="[email protected]")
         baker.make(
             UserProfile, first_name_given="Elisabeth", last_name="Fröhlich", email="[email protected]"
@@ -483,24 +483,32 @@ def test_multiple_email_matches_trigger_error(self):
 
     @override_settings(INSTITUTION_EMAIL_DOMAINS=["institution.example.com", "internal.example.com"])
     @patch("evap.staff.tools.remove_user_from_represented_and_ccing_users")
-    def test_handles_users(self, mock_remove):
+    def test_handles_users(self, mock_remove: MagicMock) -> None:
         mock_remove.return_value = ["This text is supposed to be visible on the website."]
         testuser1 = baker.make(UserProfile, email="[email protected]")
         testuser2 = baker.make(UserProfile, email="[email protected]")
         testuser1.delegates.set([testuser2])
         baker.make(UserProfile, email="[email protected]")
-        contribution1 = baker.make(Contribution)
         semester = baker.make(Semester, participations_are_archived=True)
+        course = baker.make(Course, semester=semester)
+        responsible = baker.make(
+            UserProfile, email="[email protected]", courses_responsible_for=[course]
+        )
         evaluation = baker.make(
             Evaluation,
-            course=baker.make(Course, semester=semester),
-            _participant_count=0,
-            _voter_count=0,
+            course=course,
+            participants=[responsible],
+            voters=[responsible],
+            vote_start_datetime=datetime.date(1900, 12, 1),
+            vote_end_date=datetime.date(1900, 12, 1),
+            _participant_count=1,
+            _voter_count=1,
         )
-        contribution2 = baker.make(Contribution, evaluation=evaluation)
-        baker.make(UserProfile, email="[email protected]", contributions=[contribution1])
+        baker.make(UserProfile, email="[email protected]", contributions=[baker.make(Contribution)])
         contributor2 = baker.make(
-            UserProfile, email="[email protected]", contributions=[contribution2]
+            UserProfile,
+            email="[email protected]",
+            contributions=[baker.make(Contribution, evaluation=evaluation)],
         )
         testuser1.cc_users.set([contributor2])
 
@@ -512,13 +520,15 @@ def test_handles_users(self, mock_remove):
         response = form.submit(name="operation", value="test")
 
         self.assertIn(
-            "1 will be updated, 1 will be deleted and 1 will be marked inactive. 1 new users will be created.", response
+            "1 will be updated, 1 will be deleted and 2 will be marked inactive. 1 new users will be created.", response
         )
+        self.assertIn("1 participation of responsible would be removed due to inactivity.", response)
+
         self.assertIn("[email protected] > [email protected]", response)
         self.assertIn(mock_remove.return_value[0], response)
-        self.assertEqual(mock_remove.call_count, 2)
+        self.assertEqual(mock_remove.call_count, 3)
         calls = [[call[0][0].email, call[0][2]] for call in mock_remove.call_args_list]
-        self.assertEqual(calls, [[testuser2.email, True], [contributor2.email, True]])
+        self.assertEqual(calls, [[testuser2.email, True], [contributor2.email, True], [responsible.email, True]])
         mock_remove.reset_mock()
 
         form = response.forms["user-bulk-update-form"]
@@ -542,19 +552,18 @@ def test_handles_users(self, mock_remove):
         # contributor1 should still be active, contributor2 should have been set to inactive
         self.assertTrue(UserProfile.objects.get(email="[email protected]").is_active)
         self.assertFalse(UserProfile.objects.get(email="[email protected]").is_active)
-        # all should be active except for contributor2
-        self.assertEqual(UserProfile.objects.filter(is_active=True).count(), len(expected_users) - 1)
+        # all should be active except for contributor2, responsible
+        self.assertEqual(UserProfile.objects.filter(is_active=True).count(), len(expected_users) - 2)
 
         self.assertEqual(set(UserProfile.objects.all()), expected_users)
 
-        # mock gets called for every user to be deleted (once for the test run and once for the real run)
         self.assertIn(mock_remove.return_value[0], response)
-        self.assertEqual(mock_remove.call_count, 2)
+        self.assertEqual(mock_remove.call_count, 3)
         calls = [[call[0][0].email, call[0][2]] for call in mock_remove.call_args_list]
-        self.assertEqual(calls, [[testuser2.email, False], [contributor2.email, False]])
+        self.assertEqual(calls, [[testuser2.email, False], [contributor2.email, False], [responsible.email, False]])
 
     @override_settings(DEBUG=False)
-    def test_wrong_files_dont_crash(self):
+    def test_wrong_files_dont_crash(self) -> None:
         page = self.app.get(self.url, user=self.manager)
         form = page.forms["user-bulk-update-form"]
         form["user_file"] = ("import.xls", self.random_excel_file_content)