Semesters not ordered correctly in evaluation selection on person management page (#2399)

* add option to disable standard tomselect sorting

according to tomselect docs by default the result is sorted by $score so the value or group which matches the sorting best.
But we want to order the groups by our sorting with summer and winter terms.
The sortField option here disables that and maintains the original order of options
(see https://tom-select.js.org/docs/)

Author: jooooosef

evap/evaluation/templates/base.html

@@ -164,6 +164,9 @@
                         plugins: {},
                         hideSelected: false,
                     };
+                    if (element.hasAttribute("tomselect-no-sort")) {
+                        baseOptions.sortField = [{field:'$order'},{field:'$score'}];
+                    }
                     if(element.hasAttribute("data-tomselect-fullwidth")) {
                         // span needed to the "remove this icon" button is right-aligned
                         baseOptions.render.item = (data, escape) => `<div class="w-100"><span class="w-100">${ escape(data.text) }</span></div>`;

evap/staff/forms.py

@@ -142,6 +142,7 @@ def __init__(self, *args, **kwargs):
                 choices += [(semester.name, evaluation_choices)]
 
         self.fields["evaluation"].choices = choices
+        self.fields["evaluation"].widget.attrs["tomselect-no-sort"] = ""
 
     def clean(self):
         if self.evaluation_selection_required and self.cleaned_data.get("evaluation") is None: