Skip to content

Commit c7c6ee6

Browse files
LinqLoverrichardebelingjanno42niklasmohrin
authored
Mobile improvements (#2054)
* avoid overflows in rewards overview on mobile * make navbar menu scrollable for small display heights * make footer horizontally scrollable on small screens The previous behavior was the footer became wider than the screen and the entire page width was increased. * contact form: enable line breaks in anonymous sender button * remove horizontal overflows in contributor index * avoid horizontal overflows of percentage value in distribution bars * avoid horizontal overflows in grade views * avoid horizontal overflows in contributor evaluation form * avoid horizontal overflows in some staff views * make staff overview mobile-friendly * avoid horizontal overflows of breadcrumb arrow * avoid horizontal overflows in staff faq views * fix navbar menus on desktop regression from regression from 75af5b2 --------- Co-authored-by: Richard Ebeling <[email protected]> Co-authored-by: Johannes Wolf <[email protected]> Co-authored-by: Niklas Mohrin <[email protected]>
1 parent 06bfc12 commit c7c6ee6

32 files changed

+181
-155
lines changed

‎evap/contributor/templates/contributor_evaluation_form.html

+8-6
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,12 @@
55
{% block title %}{% trans 'Your EvaP' %} - {{ block.super }}{% endblock %}
66

77
{% block breadcrumb_bar %}
8-
<ul class="breadcrumb">
9-
<li class="breadcrumb-item">{{ evaluation.course.semester.name }}</li>
10-
<li class="breadcrumb-item">{{ evaluation.full_name }}</li>
11-
</ul>
8+
<div class="breadcrumb-bar">
9+
<ul class="breadcrumb">
10+
<li class="breadcrumb-item">{{ evaluation.course.semester.name }}</li>
11+
<li class="breadcrumb-item">{{ evaluation.full_name }}</li>
12+
</ul>
13+
</div>
1214
{% endblock %}
1315

1416
{% block content %}
@@ -59,7 +61,7 @@ <h5 class="card-title">{% trans 'Course data' %}</h5>
5961
</div>
6062
</div>
6163
<div class="card mb-3">
62-
<div class="card-body">
64+
<div class="card-body table-responsive">
6365
<div class="d-flex">
6466
<h5 class="card-title me-auto">{% trans 'Evaluation data' %}</h5>
6567
{% if evaluation.allow_editors_to_edit %}
@@ -80,7 +82,7 @@ <h5 class="card-title me-auto">{% trans 'Evaluation data' %}</h5>
8082
</div>
8183
</div>
8284
<div class="card mb-3">
83-
<div class="card-body">
85+
<div class="card-body table-responsive">
8486
{% include 'contribution_formset.html' with formset=formset staff=False editable=editable %}
8587
</div>
8688
</div>

‎evap/contributor/templates/contributor_index.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
</div>
1818
{% if user.is_delegate %}
1919
<div class="btn-switch btn-switch-light ms-2 d-print-none">
20-
<div class="btn-switch-label"><span class="fas fa-people-arrows-left-right"></span> {% trans 'Delegated evaluations' %}</div>
20+
<div class="btn-switch-label text-break break-spaces"><span class="fas fa-people-arrows-left-right"></span> {% trans 'Delegated evaluations' %}</div>
2121
<div class="btn-switch btn-group">
2222
<a href="{% url 'contributor:index' %}?show_delegated=true" role="button" class="btn btn-sm btn-light{% if show_delegated %} active{% endif %}">
2323
{% trans 'Show' %}
@@ -42,7 +42,7 @@
4242
<div class="card-header">
4343
{{ semester.semester_name }}
4444
</div>
45-
<div class="card-body">
45+
<div class="card-body table-responsive">
4646
<table class="table table-seamless-links table-vertically-aligned">
4747
<thead>
4848
<tr>

‎evap/development/templates/development_components.html

+7-5
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,13 @@
33
{% block title %}{% trans 'Development' %} - {{ block.super }}{% endblock %}
44

55
{% block breadcrumb_bar %}
6-
<ul class="breadcrumb">
7-
{% block breadcrumb %}
8-
<li class="breadcrumb-item">{% trans 'Development' %}</li>
9-
{% endblock %}
10-
</ul>
6+
<div class="breadcrumb-bar">
7+
<ul class="breadcrumb">
8+
{% block breadcrumb %}
9+
<li class="breadcrumb-item">{% trans 'Development' %}</li>
10+
{% endblock %}
11+
</ul>
12+
</div>
1113
{% endblock %}
1214

1315
{% block content %}

‎evap/evaluation/templates/contact_modal.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ <h5 class="modal-title" id="{{ modal_id }}Label">{{ title }}</h5>
3030
<input type="radio" class="btn-check" name="{{ modal_id }}RadioGroup" id="{{ modal_id }}SenderName" checked>
3131
<label class="btn btn-sm btn-outline-primary text-break" for="{{ modal_id }}SenderName">{{ user.full_name }}</label>
3232
<input type="radio" class="btn-check" name="{{ modal_id }}RadioGroup" id="{{ modal_id }}AnonymousName">
33-
<label class="btn btn-sm btn-outline-primary" for="{{ modal_id }}AnonymousName">{% trans 'Anonymous' %}</label>
33+
<label class="btn btn-sm btn-outline-primary text-break" for="{{ modal_id }}AnonymousName">{% trans 'Anonymous' %}</label>
3434
</div>
3535
{% else %}
3636
<input type="text" class="form-control mx-auto text-break" id="{{ modal_id }}SenderName" disabled value="{{ user.full_name }}"/>

‎evap/evaluation/templates/footer.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<div class="vote-bg-orange" style="width: 6%;"></div>
77
<div class="vote-bg-red" style="width: 3%;"></div>
88
</div>
9-
<nav class="navbar navbar-expand">
9+
<nav class="navbar navbar-expand overflow-x-scroll">
1010
<div class="collapse navbar-collapse justify-content-between">
1111
<ul class="navbar-nav justify-content-start">
1212
<li class="nav-item my-auto">

‎evap/grades/templates/grades_base.html

+11-9
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,15 @@
33
{% block title %}{% trans 'Grade publishing' %} - {{ block.super }}{% endblock %}
44

55
{% block breadcrumb_bar %}
6-
<ul class="breadcrumb">
7-
{% block breadcrumb %}
8-
{% if disable_breadcrumb_grades or not user.is_grade_publisher %}
9-
<li class="breadcrumb-item">{% trans 'Grade publishing' %}</li>
10-
{% else %}
11-
<li class="breadcrumb-item"><a href="{% url 'grades:index' %}">{% trans 'Grade publishing' %}</a></li>
12-
{% endif %}
13-
{% endblock %}
14-
</ul>
6+
<div class="breadcrumb-bar">
7+
<ul class="breadcrumb">
8+
{% block breadcrumb %}
9+
{% if disable_breadcrumb_grades or not user.is_grade_publisher %}
10+
<li class="breadcrumb-item">{% trans 'Grade publishing' %}</li>
11+
{% else %}
12+
<li class="breadcrumb-item"><a href="{% url 'grades:index' %}">{% trans 'Grade publishing' %}</a></li>
13+
{% endif %}
14+
{% endblock %}
15+
</ul>
16+
</div>
1517
{% endblock %}

‎evap/grades/templates/grades_course_view.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ <h3 class="mb-3">{{ course.name }} ({{ semester.name }})</h3>
99
<div class="card-header">
1010
{% trans 'Uploaded grade documents' %}
1111
</div>
12-
<div class="card-body">
12+
<div class="card-body table-responsive">
1313
{% if grade_documents %}
1414
<table class="table table-striped table-vertically-aligned">
1515
<thead>

‎evap/grades/templates/grades_semester_view.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ <h3 class="col-8 mb-0">
3030
<div class="card-header">
3131
{% trans 'Courses' %}
3232
</div>
33-
<div class="card-body">
33+
<div class="card-body table-responsive">
3434
{% if courses %}
3535
<table class="table table-striped grade-course-table table-vertically-aligned">
3636
<thead>

‎evap/results/templates/results_evaluation_detail.html

+6-4
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@
77
{% block title %}{{ evaluation.full_name }} - {{ evaluation.course.semester.name }} - {% trans 'Results' %} - {{ block.super }}{% endblock %}
88

99
{% block breadcrumb_bar %}
10-
<ul class="breadcrumb">
11-
<li class="breadcrumb-item">{{ evaluation.course.semester.name }}</li>
12-
<li class="breadcrumb-item">{{ evaluation.full_name }}</li>
13-
</ul>
10+
<div class="breadcrumb-bar">
11+
<ul class="breadcrumb">
12+
<li class="breadcrumb-item">{{ evaluation.course.semester.name }}</li>
13+
<li class="breadcrumb-item">{{ evaluation.full_name }}</li>
14+
</ul>
15+
</div>
1416
{% endblock %}
1517

1618
{% block content %}

‎evap/rewards/templates/rewards_index.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<div class="card-header">
1616
{% trans 'Redeem points' %}
1717
</div>
18-
<div class="card-body">
18+
<div class="card-body table-responsive">
1919
<p><b>{% trans 'Total points available' %}: {{ total_points_available }}</b></p>
2020
{% if total_points_available > 0 %}
2121
{% if events %}
@@ -62,7 +62,7 @@
6262
<div class="card-header">
6363
{% trans 'Reward points history' %}
6464
</div>
65-
<div class="card-body">
65+
<div class="card-body table-responsive">
6666
{% if reward_point_actions %}
6767
<table class="table table-striped">
6868
<thead>

‎evap/rewards/templates/rewards_reward_point_redemption_event_list.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div class="card-header">
22
{% trans title %}
33
</div>
4-
<div class="card-body">
4+
<div class="card-body table-responsive">
55
{% if events %}
66
<table class="table table-striped">
77
<thead>

‎evap/staff/templates/staff_base.html

+11-9
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,15 @@
33
{% block title %}{% trans 'Manage' %} - {{ block.super }}{% endblock %}
44

55
{% block breadcrumb_bar %}
6-
<ul class="breadcrumb">
7-
{% block breadcrumb %}
8-
{% if disable_breadcrumb_manager or not user.is_manager %}
9-
<li class="breadcrumb-item">{% trans 'Manage' %}</li>
10-
{% else %}
11-
<li class="breadcrumb-item"><a href="{% url 'staff:index' %}">{% trans 'Manage' %}</a></li>
12-
{% endif %}
13-
{% endblock %}
14-
</ul>
6+
<div class="breadcrumb-bar">
7+
<ul class="breadcrumb">
8+
{% block breadcrumb %}
9+
{% if disable_breadcrumb_manager or not user.is_manager %}
10+
<li class="breadcrumb-item">{% trans 'Manage' %}</li>
11+
{% else %}
12+
<li class="breadcrumb-item"><a href="{% url 'staff:index' %}">{% trans 'Manage' %}</a></li>
13+
{% endif %}
14+
{% endblock %}
15+
</ul>
16+
</div>
1517
{% endblock %}

‎evap/staff/templates/staff_course_type_index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
{{ formset.management_form }}
2020

2121
<div class="card mb-3">
22-
<div class="card-body">
22+
<div class="card-body table-responsive">
2323
<table id="course_types_table" class="table table-vertically-aligned">
2424
<thead>
2525
<tr>

‎evap/staff/templates/staff_degree_index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
{{ formset.management_form }}
1616

1717
<div class="card mb-3">
18-
<div class="card-body">
18+
<div class="card-body table-responsive">
1919
<table id="degree_table" class="table table-vertically-aligned">
2020
<thead>
2121
<tr>

‎evap/staff/templates/staff_evaluation_form.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ <h3>
2828
</div>
2929
</div>
3030
<div class="card mb-3">
31-
<div class="card-body">
31+
<div class="card-body table-responsive">
3232
{% include 'contribution_formset.html' with formset=formset manager=True editable=editable %}
3333
</div>
3434
</div>

‎evap/staff/templates/staff_faq_index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
{{ formset.management_form }}
1616

1717
<div class="card mb-3">
18-
<div class="card-body">
18+
<div class="card-body table-responsive">
1919
<table id="section_table" class="table table-vertically-aligned">
2020
<thead>
2121
<tr>

‎evap/staff/templates/staff_faq_section.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
{{ formset.management_form }}
1717

1818
<div class="card mb-3">
19-
<div class="card-body">
19+
<div class="card-body table-responsive">
2020
<table id="question_table" class="table">
2121
<thead>
2222
<tr>

0 commit comments

Comments
 (0)