-
-
Notifications
You must be signed in to change notification settings - Fork 9
Expand file tree
/
Copy pathprefer-static-regex.ts
More file actions
64 lines (58 loc) · 1.57 KB
/
prefer-static-regex.ts
File metadata and controls
64 lines (58 loc) · 1.57 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
import type {Rule} from 'eslint';
import type {Literal, NewExpression, RegExpLiteral} from 'estree';
const statefulFlags = /[gy]/;
function isStaticNewRegExp(node: NewExpression): boolean {
if (
node.callee.type !== 'Identifier' ||
node.callee.name !== 'RegExp' ||
node.arguments.length === 0 ||
node.arguments.length > 2
) {
return false;
}
if (
!node.arguments.every(
(arg) => arg.type === 'Literal' && typeof arg.value === 'string'
)
) {
return false;
}
const flagsArg = node.arguments[1] as Literal | undefined;
if (flagsArg && statefulFlags.test(flagsArg.value as string)) {
return false;
}
return true;
}
export const preferStaticRegex: Rule.RuleModule = {
meta: {
type: 'suggestion',
docs: {
description:
'Prefer defining regular expressions at module scope to avoid re-compilation on every function call',
recommended: true
},
schema: [],
messages: {
preferStatic:
'Move this regular expression to module scope to avoid re-compilation on every call.'
}
},
create(context) {
return {
':function Literal[regex]'(node: Rule.Node) {
const {flags} = (node as unknown as RegExpLiteral).regex;
if (statefulFlags.test(flags)) {
return;
}
context.report({node, messageId: 'preferStatic'});
},
':function NewExpression'(
node: NewExpression & Rule.NodeParentExtension
) {
if (isStaticNewRegExp(node)) {
context.report({node, messageId: 'preferStatic'});
}
}
};
}
};