improve key hash verification

dobrac · dobrac · commit 20a3f49d5698 · 2025-02-14T14:14:38.000-08:00
diff --git a/packages/api/internal/auth/key.go b/packages/api/internal/auth/key.go
@@ -45,12 +45,11 @@ func GenerateKey(prefix string) (Key, error) {
 }
 
 func VerifyKey(prefix string, key string) (string, error) {
-	parts := strings.Split(key, prefix)
-	if len(parts) != 2 {
+	if !strings.HasPrefix(key, prefix) {
 		return "", fmt.Errorf("invalid key prefix")
 	}
 
-	keyValue := parts[1]
+	keyValue := key[len(prefix):]
 	keyBytes, err := hex.DecodeString(keyValue)
 	if err != nil {
 		return "", fmt.Errorf("invalid key")

Original file line number	Diff line number	Diff line change
`@@ -45,12 +45,11 @@ func GenerateKey(prefix string) (Key, error) {`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`func VerifyKey(prefix string, key string) (string, error) {`
`48`		`- parts := strings.Split(key, prefix)`
`49`		`- if len(parts) != 2 {`
	`48`	`+ if !strings.HasPrefix(key, prefix) {`
`50`	`49`	`return "", fmt.Errorf("invalid key prefix")`
`51`	`50`	`}`
`52`	`51`
`53`		`- keyValue := parts[1]`
	`52`	`+ keyValue := key[len(prefix):]`
`54`	`53`	`keyBytes, err := hex.DecodeString(keyValue)`
`55`	`54`	`if err != nil {`
`56`	`55`	`return "", fmt.Errorf("invalid key")`