address comments

JacksonYao287 · JacksonYao287 · commit e4bc0290ce4f · 2025-05-15T00:30:20.000-07:00
diff --git a/src/lib/homestore_backend/gc_manager.cpp b/src/lib/homestore_backend/gc_manager.cpp
@@ -88,8 +88,8 @@ bool GCManager::is_eligible_for_gc(std::shared_ptr< HeapChunkSelector::ExtendedV
 }
 
 void GCManager::scan_chunks_for_gc() {
-    // in every iteration, we will select at most RESERVED_CHUNK_NUM_PER_PDEV gc tasks
-    auto max_task_num = RESERVED_CHUNK_NUM_PER_PDEV;
+    // in every iteration, we will select at most 2 * RESERVED_CHUNK_NUM_PER_PDEV gc tasks
+    auto max_task_num = 2 * (RESERVED_CHUNK_NUM_PER_PDEV - RESERVED_CHUNK_NUM_DEDICATED_FOR_EGC);
 
     for (const auto& [_, chunk] : m_chunk_selector->get_all_chunks()) {
         if (is_eligible_for_gc(chunk)) {

Original file line number	Diff line number	Diff line change
`@@ -88,8 +88,8 @@ bool GCManager::is_eligible_for_gc(std::shared_ptr< HeapChunkSelector::ExtendedV`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`void GCManager::scan_chunks_for_gc() {`
`91`		`- // in every iteration, we will select at most RESERVED_CHUNK_NUM_PER_PDEV gc tasks`
`92`		`- auto max_task_num = RESERVED_CHUNK_NUM_PER_PDEV;`
	`91`	`+ // in every iteration, we will select at most 2 * RESERVED_CHUNK_NUM_PER_PDEV gc tasks`
	`92`	`+ auto max_task_num = 2 * (RESERVED_CHUNK_NUM_PER_PDEV - RESERVED_CHUNK_NUM_DEDICATED_FOR_EGC);`
`93`	`93`
`94`	`94`	`for (const auto& [_, chunk] : m_chunk_selector->get_all_chunks()) {`
`95`	`95`	`if (is_eligible_for_gc(chunk)) {`