Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Commit be60239

Browse files
ci: release (#2403)
1 parent 6fea187 commit be60239

File tree

5 files changed

+18
-13
lines changed

5 files changed

+18
-13
lines changed

.changeset/gentle-foxes-push.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# eBayUI-Core Changelog
22

3+
## 14.6.9
4+
5+
### Patch Changes
6+
7+
- [#2402](https://github.com/eBay/ebayui-core/pull/2402) [`6fea187`](https://github.com/eBay/ebayui-core/commit/6fea187704aa350922c4cc4009a2cbea929340a0) Thanks [@agliga](https://github.com/agliga)! - fix(combobox): reverted removing of view all options
8+
39
## 14.6.8
410

511
### Patch Changes

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@ebay/ebayui-core",
3-
"version": "14.6.8",
3+
"version": "14.6.9",
44
"description": "Collection of core eBay components; considered to be the building blocks for all composite structures, pages & apps.",
55
"keywords": [
66
"marko-components"

src/components/ebay-combobox/component.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,11 @@ interface ComboboxInput extends Omit<Marko.Input<"input">, `on${string}`> {
2828
"list-selection"?: "manual" | "automatic";
2929
"floating-label"?: boolean;
3030
"view-all-options"?: boolean;
31-
button?: Marko.Input<"button"> & Marko.AttrTag<{
32-
htmlAttributes?: Record<string, unknown>;
33-
renderBody?: Marko.Body;
34-
}>;
31+
button?: Marko.Input<"button"> &
32+
Marko.AttrTag<{
33+
htmlAttributes?: Record<string, unknown>;
34+
renderBody?: Marko.Body;
35+
}>;
3536
options?: Marko.AttrTag<ComboboxOption>;
3637
"chevron-size"?: "large";
3738
"on-focus"?: (event: ComboboxEvent) => void;
@@ -235,7 +236,10 @@ export default class Combobox extends Marko.Component<Input, State> {
235236
this.lastValue = input.value;
236237
this.state = {
237238
currentValue: this.lastValue,
238-
viewAllOptions: (this.state && this.state.viewAllOptions) || input.viewAllOptions || false,
239+
viewAllOptions:
240+
(this.state && this.state.viewAllOptions) ||
241+
input.viewAllOptions ||
242+
false,
239243
};
240244
if (this.expander) {
241245
this.expandedChange = input.expanded !== this.expanded;

0 commit comments

Comments
 (0)