From 0c657ee5779761b734795789d69822e703e4b72d Mon Sep 17 00:00:00 2001 From: Juan Lopez Fernandez Date: Tue, 25 Nov 2025 10:24:43 +0100 Subject: [PATCH 1/2] Fix action notification callback Signed-off-by: Juan Lopez Fernandez --- ddsenabler_participants/src/cpp/Writer.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ddsenabler_participants/src/cpp/Writer.cpp b/ddsenabler_participants/src/cpp/Writer.cpp index c7a35228..29fc91ee 100644 --- a/ddsenabler_participants/src/cpp/Writer.cpp +++ b/ddsenabler_participants/src/cpp/Writer.cpp @@ -268,14 +268,14 @@ void Writer::write_action_notification( TopicInfo(action.goal.request_topic().type_name, goal_request_serialized_qos), TopicInfo(action.goal.reply_topic().type_name, goal_reply_serialized_qos) ), - ServiceInfo( - TopicInfo(action.cancel.request_topic().type_name, cancel_request_serialized_qos), - TopicInfo(action.cancel.reply_topic().type_name, cancel_reply_serialized_qos) - ), ServiceInfo( TopicInfo(action.result.request_topic().type_name, result_request_serialized_qos), TopicInfo(action.result.reply_topic().type_name, result_reply_serialized_qos) ), + ServiceInfo( + TopicInfo(action.cancel.request_topic().type_name, cancel_request_serialized_qos), + TopicInfo(action.cancel.reply_topic().type_name, cancel_reply_serialized_qos) + ), TopicInfo(action.feedback.type_name, feedback_serialized_qos), TopicInfo(action.status.type_name, status_serialized_qos) )); From d322cb1d04054e79c5efbda3378ff9e04d3bcadd Mon Sep 17 00:00:00 2001 From: Juan Lopez Fernandez Date: Tue, 25 Nov 2025 10:25:14 +0100 Subject: [PATCH 2/2] Add feedback comment on action example Signed-off-by: Juan Lopez Fernandez --- ddsenabler/examples/action/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ddsenabler/examples/action/main.cpp b/ddsenabler/examples/action/main.cpp index 1b571a28..bf97855e 100644 --- a/ddsenabler/examples/action/main.cpp +++ b/ddsenabler/examples/action/main.cpp @@ -418,7 +418,7 @@ bool server_specific_logic( { std::vector fibonacci_sequence = {0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144, 233, 377, 610}; std::string json = "{\"sequence\": ["; - std::string feedback_json = "{\"partial_sequence\": ["; + std::string feedback_json = "{\"partial_sequence\": ["; // From Kilted onwardards, the feedback attribute name is "sequence" for (size_t i = 0; i < fibonacci_number; ++i) { {