Fix macOS/Clang debug warnings/errors (#185)

* [#24607] Fix macOS/Clang debug warnings/errors

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#24607] Applied uncrustify

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

---------

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

Author: Danipiza

ddspipe_core/src/cpp/types/dds/TopicQoS.cpp

@@ -25,6 +25,16 @@ namespace ddspipe {
 namespace core {
 namespace types {
 
+constexpr const DurabilityKind TopicQoS::DEFAULT_DURABILITY_QOS;
+constexpr const ReliabilityKind TopicQoS::DEFAULT_RELIABILITY_QOS;
+constexpr const OwnershipQosPolicyKind TopicQoS::DEFAULT_OWNERSHIP_QOS;
+constexpr const bool TopicQoS::DEFAULT_USE_PARTITIONS;
+constexpr const HistoryDepthType TopicQoS::DEFAULT_HISTORY_DEPTH;
+constexpr const bool TopicQoS::DEFAULT_KEYED;
+constexpr const float TopicQoS::DEFAULT_MAX_TX_RATE;
+constexpr const float TopicQoS::DEFAULT_MAX_RX_RATE;
+constexpr const unsigned int TopicQoS::DEFAULT_DOWNSAMPLING;
+
 utils::Fuzzy<TopicQoS> TopicQoS::default_topic_qos{};
 
 TopicQoS::TopicQoS()
@@ -239,18 +249,17 @@ std::ostream& operator <<(
         std::ostream& os,
         const TopicQoS& qos)
 {
-    os <<
-        "TopicQoS{" <<
-        "durability(" << qos.durability_qos << ")" <<
-        ";reliability(" << qos.reliability_qos << ")" <<
-        ";ownership(" << qos.ownership_qos << ")" <<
-        (qos.has_partitions() ? ";partitions" : "") <<
-        (qos.keyed ? ";keyed" : "") <<
-        ";depth(" << qos.history_depth << ")" <<
-        ";max_tx_rate(" << qos.max_tx_rate << ")" <<
-        ";max_rx_rate(" << qos.max_rx_rate << ")" <<
-        ";downsampling(" << qos.downsampling << ")" <<
-        "}";
+    os << "TopicQoS{"
+       << "durability(" << qos.durability_qos << ")"
+       << ";reliability(" << qos.reliability_qos << ")"
+       << ";ownership(" << qos.ownership_qos << ")"
+       << (qos.has_partitions() ? ";partitions" : "")
+       << (qos.keyed ? ";keyed" : "")
+       << ";depth(" << qos.history_depth << ")"
+       << ";max_tx_rate(" << qos.max_tx_rate << ")"
+       << ";max_rx_rate(" << qos.max_rx_rate << ")"
+       << ";downsampling(" << qos.downsampling << ")"
+       << "}";
 
     return os;
 }

ddspipe_participants/include/ddspipe_participants/reader/dds/CommonReader.hpp

@@ -85,19 +85,19 @@ class CommonReader : public BaseReader, public fastdds::dds::DataReaderListener,
     /////////////////////////
 
     virtual void on_data_available(
-            fastdds::dds::DataReader* reader);
+            fastdds::dds::DataReader* reader) override;
 
     virtual void on_sample_lost(
             fastdds::dds::DataReader* reader,
-            const fastdds::dds::SampleLostStatus& status);
+            const fastdds::dds::SampleLostStatus& status) override;
 
     virtual void on_requested_incompatible_qos(
             fastdds::dds::DataReader* reader,
-            const fastdds::dds::RequestedIncompatibleQosStatus& status);
+            const fastdds::dds::RequestedIncompatibleQosStatus& status) override;
 
     virtual void on_inconsistent_topic(
             fastdds::dds::Topic* topic,
-            fastdds::dds::InconsistentTopicStatus status);
+            fastdds::dds::InconsistentTopicStatus status) override;
 
 protected:
 

ddspipe_participants/include/ddspipe_participants/reader/rtps/CommonReader.hpp

@@ -282,7 +282,7 @@ class CommonReader : public BaseReader, public fastdds::rtps::ReaderListener
             const core::types::DdsTopic& topic) noexcept;
 
     //! Topic Description to create RTPS Reader
-    fastdds::rtps::TopicDescription reckon_topic_description_(
+    static fastdds::rtps::TopicDescription reckon_topic_description_(
             const core::types::DdsTopic& topic) noexcept;
 
     //! Reader QoS to create RTPS Reader

ddspipe_participants/include/ddspipe_participants/writer/rtps/CommonWriter.hpp

@@ -259,7 +259,7 @@ class CommonWriter : public BaseWriter, public fastdds::rtps::WriterListener
             const core::types::DdsTopic& topic) noexcept;
 
     //! Topic Description to create RTPS Writer
-    fastdds::rtps::TopicDescription reckon_topic_description_(
+    static fastdds::rtps::TopicDescription reckon_topic_description_(
             const core::types::DdsTopic& topic) noexcept;
 
     //! QoS for RTPS Writer