Replace invalid domain-id core-dump with clean validation errors (#178)

* [#24280] Replaced invalid domain-id core-dump with clean validation errors

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#24280] Applied revision

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#24280] Applied revision

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#24280] Fixed 'invalid_domain' test

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#24280] Refactor YamlsReader domain tag

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#24280] Applied revision

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

---------

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

Author: Danipiza

ddspipe_core/src/cpp/configuration/DdsPublishingConfiguration.cpp

@@ -32,7 +32,7 @@ bool DdsPublishingConfiguration::is_valid(
         return true;
     }
 
-    if (domain < 0 || domain > 255)
+    if (domain > types::DomainId::MAX_DOMAIN_ID)
     {
         error_msg << "Invalid domain: " << domain;
         return false;

ddspipe_yaml/src/cpp/YamlReader_types.cpp

@@ -17,6 +17,9 @@
  *
  */
 
+#include <cmath>
+#include <limits>
+
 #include <cpp_utils/Log.hpp>
 #include <cpp_utils/memory/Heritable.hpp>
 #include <cpp_utils/utils.hpp>
@@ -50,6 +53,25 @@ namespace yaml {
 using namespace eprosima::ddspipe::core::types;
 using namespace eprosima::ddspipe::participants::types;
 
+static void check_and_set_domain_(
+        const double domain_value,
+        DomainIdType& domain_id)
+{
+    const auto max_domain_value = static_cast<double>(DomainId::MAX_DOMAIN_ID);
+    const bool is_integer_domain = std::floor(domain_value) == domain_value;
+
+    if (!std::isfinite(domain_value) || !is_integer_domain ||
+            domain_value < 0 || domain_value > max_domain_value)
+    {
+        // Mark as invalid and let configuration validation report a clear range error
+        domain_id = static_cast<DomainIdType>(max_domain_value + 1);
+    }
+    else
+    {
+        domain_id = static_cast<DomainIdType>(domain_value);
+    }
+}
+
 template<>
 DDSPIPE_YAML_DllAPI
 TransportDescriptors YamlReader::get<TransportDescriptors>(
@@ -147,7 +169,11 @@ DomainId YamlReader::get<DomainId>(
 {
     // Domain id required
     DomainId domain;
-    domain.domain_id = get_scalar<DomainIdType>(yml);
+
+    // Read as double so numeric YAML values such as 0.5 do not fail with a cast error
+    // Invalid values are marked and validated later in the configuration checks
+    check_and_set_domain_(get_scalar<double>(yml), domain.domain_id);
+
     return domain;
 }
 
@@ -315,7 +341,9 @@ void YamlReader::fill(
     // Optional domain
     if (is_tag_present(yml, DDS_PUBLISHING_DOMAIN_TAG))
     {
-        object.domain = get<DomainIdType>(yml, DDS_PUBLISHING_DOMAIN_TAG, version);
+        // Read as double so numeric YAML values such as 0.5 do not fail with a cast error.
+        // Invalid values are marked and validated later in the configuration checks.
+        check_and_set_domain_(get<double>(yml, DDS_PUBLISHING_DOMAIN_TAG, version), object.domain);
     }
 
     // Optional topic name

ddspipe_yaml/test/unittest/yaml_reader/log_configuration/YamlReaderLogConfiguration.cpp

@@ -154,7 +154,7 @@ TEST(YamlReaderLogConfiguration, invalid_domain)
     ASSERT_FALSE(conf.is_valid(error_msg));
 
     // Verify that the error message is correct
-    ASSERT_EQ(error_msg.to_string(), "Invalid domain: 300");
+    ASSERT_EQ(error_msg.to_string(), "Invalid domain: 233"); // Max domain value (232) + 1
 }
 
 /**