[#25513] Solved more data races

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

Author: Danipiza

ddspipe_participants/include/ddspipe_participants/participant/dds/CommonParticipant.hpp

@@ -319,6 +319,10 @@ class CommonParticipant : public core::IParticipant
     //! <Topics <Writer_guid, Partitions set>>
     std::map<std::string, std::map<std::string, std::string>> partition_names;
 
+    //! Protects concurrent access to \c partition_names, which is written from the DDS discovery
+    //! thread (add/update/delete/clear_topic_partition) and read from other threads (topic_partitions).
+    mutable std::mutex partition_names_mutex_;
+
     // Filter partitions set
     std::set<std::string> partition_filter_set_;
     // Filter content_topicfilter dict

ddspipe_participants/src/cpp/participant/dds/CommonParticipant.cpp

@@ -115,6 +115,7 @@ core::types::TopicQoS CommonParticipant::topic_qos() const noexcept
 
 std::map<std::string, std::map<std::string, std::string>> CommonParticipant::topic_partitions() const noexcept
 {
+    std::lock_guard<std::mutex> lock(partition_names_mutex_);
     return partition_names;
 }
 
@@ -578,6 +579,7 @@ bool CommonParticipant::add_topic_partition(
         const std::string& writer_guid,
         const std::string& partition)
 {
+    std::lock_guard<std::mutex> lock(partition_names_mutex_);
     if (partition_names.find(topic_name) != partition_names.end())
     {
         // the topic exists
@@ -604,6 +606,7 @@ bool CommonParticipant::update_topic_partition(
         const std::string& writer_guid,
         const std::string& partition)
 {
+    std::lock_guard<std::mutex> lock(partition_names_mutex_);
     if (partition_names.find(topic_name) == partition_names.end())
     {
         // the topic dont exists
@@ -627,6 +630,7 @@ bool CommonParticipant::delete_topic_partition(
         const std::string& writer_guid,
         const std::string& partition)
 {
+    std::lock_guard<std::mutex> lock(partition_names_mutex_);
     if (partition_names.find(topic_name) == partition_names.end())
     {
         // the topic dont exists
@@ -646,6 +650,7 @@ bool CommonParticipant::delete_topic_partition(
 
 void CommonParticipant::clear_topic_partitions()
 {
+    std::lock_guard<std::mutex> lock(partition_names_mutex_);
     partition_names.clear();
 }