Skip to content

Commit 285c30c

Browse files
mergify[bot]cferreiragonzjuanlofer-eprosima
authored
Fix RTPSParticipantAttributes internal data races (#6370) (#6387)
* Refs #23923: Take mutex in getter and env file callback * Refs #23923: Only update mutable attributes * Refs #23923: Copy attributes in getter * Refs #23923: Undo copy attributes * Refs #23923: Avoid calling get_attributes in SecurityManager constructor * Refs #23923: Copy attributes * Refs #23923: Protect missing cases * Refs #23923: Create new method to avoid API break * Refs #23923: Doxygen & TODO in next major * Refs #23923: Copy method in RTPSParticipant * Refs #23923: Mock and tests changes * Refs #23923: Revision * Refs #23923: Add missing mutable attribute * Refs #23923: Create const copy * Refs #23923: Uncrustify * Refs #23923: Spelling * Refs #23923: Split const and mutable RTPSParticipantAttributes * Refs #23923: Review - Fix Mutable & Constant attributes * Refs #23923: Review - Apply methods and composition of BuiltinAttributes * Refs #23923: Review - Update Tests * Refs #23923: Review - Add ConstantDiscoverySettings * Refs #23923: Solve using statement visibility * Refs #23923: Uncrustify * Refs #23923: Store constant attributes set at 'setup_' methods * Refs #23923: Init const attributes and update later * Refs #23923: Review - Improve doxygen --------- (cherry picked from commit 7dd4b4d) Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
1 parent 6c173cb commit 285c30c

43 files changed

Lines changed: 1406 additions & 208 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

include/fastdds/dds/publisher/DataWriter.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ class DataWriter : public DomainEntity
484484
*
485485
* @param [out] subscription_data subscription data struct
486486
* @param subscription_handle InstanceHandle_t of the subscription
487-
* @return RETCODE_OK if successfull, RETCODE_BAD_PARAMETER otherwise
487+
* @return RETCODE_OK if successful, RETCODE_BAD_PARAMETER otherwise
488488
*/
489489
FASTDDS_EXPORTED_API ReturnCode_t get_matched_subscription_data(
490490
SubscriptionBuiltinTopicData& subscription_data,
@@ -494,7 +494,7 @@ class DataWriter : public DomainEntity
494494
* @brief Fills the given vector with the InstanceHandle_t of matched DataReaders
495495
*
496496
* @param [out] subscription_handles Vector where the InstanceHandle_t are returned
497-
* @return RETCODE_OK if successfull, RETCODE_ERROR otherwise
497+
* @return RETCODE_OK if successful, RETCODE_ERROR otherwise
498498
*/
499499
FASTDDS_EXPORTED_API ReturnCode_t get_matched_subscriptions(
500500
std::vector<InstanceHandle_t>& subscription_handles) const;

0 commit comments

Comments
 (0)