Refs #21358: Assert correctiosn fro tests

Javier Gil Aviles · Javier Gil Aviles · commit 54c2683c86c7 · 2025-06-24T09:49:54.000+02:00
Signed-off-by: Javier Gil Aviles &lt;javiergil@eprosima.com&gt;
diff --git a/src/cpp/fastdds/xtypes/dynamic_types/DynamicTypeBuilderImpl.cpp b/src/cpp/fastdds/xtypes/dynamic_types/DynamicTypeBuilderImpl.cpp
@@ -61,8 +61,9 @@ DynamicTypeBuilderImpl::DynamicTypeBuilderImpl(
                                                                      members_.back())};
             if (!member_impl)
             {
+                assert(false);
                 EPROSIMA_LOG_ERROR(DYN_TYPES,
-                        "Internal error: last member is not a DynamicTypeMemberImpl");
+                        "Internal error: last member is not a DynamicTypeMemberImpl.");
             }
             else
             {
diff --git a/src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp b/src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp
@@ -577,9 +577,13 @@ void PDPSimple::unmatch_pdp_remote_endpoints(
         auto endpoints = dynamic_cast<fastdds::rtps::SimplePDPEndpoints*>(builtin_endpoints_.get());
         if (nullptr == endpoints)
         {
+            assert(false);
             EPROSIMA_LOG_ERROR(RTPS_PDP,
                     "unmatch_pdp_remote_endpoints(): builtin_endpoints_ is null or wrong type");
             return;
+        } else
+        {
+            assert(true);
         }
 
         guid.entityId = c_EntityId_SPDPWriter;

Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,9 @@ DynamicTypeBuilderImpl::DynamicTypeBuilderImpl(`
`61`	`61`	`members_.back())};`
`62`	`62`	`if (!member_impl)`
`63`	`63`	`{`
	`64`	`+ assert(false);`
`64`	`65`	`EPROSIMA_LOG_ERROR(DYN_TYPES,`
`65`		`- "Internal error: last member is not a DynamicTypeMemberImpl");`
	`66`	`+ "Internal error: last member is not a DynamicTypeMemberImpl.");`
`66`	`67`	`}`
`67`	`68`	`else`
`68`	`69`	`{`
Original file line number	Diff line number	Diff line change
`@@ -577,9 +577,13 @@ void PDPSimple::unmatch_pdp_remote_endpoints(`
`577`	`577`	`auto endpoints = dynamic_cast<fastdds::rtps::SimplePDPEndpoints*>(builtin_endpoints_.get());`
`578`	`578`	`if (nullptr == endpoints)`
`579`	`579`	`{`
	`580`	`+ assert(false);`
`580`	`581`	`EPROSIMA_LOG_ERROR(RTPS_PDP,`
`581`	`582`	`"unmatch_pdp_remote_endpoints(): builtin_endpoints_ is null or wrong type");`
`582`	`583`	`return;`
	`584`	`+ } else`
	`585`	`+ {`
	`586`	`+ assert(true);`
`583`	`587`	`}`
`584`	`588`
`585`	`589`	`guid.entityId = c_EntityId_SPDPWriter;`