Refs #21358: Delate assert(false) and add log error

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Author: Javier Gil Aviles

src/cpp/fastdds/xtypes/dynamic_types/DynamicDataImpl.cpp

@@ -4302,6 +4302,72 @@ ReturnCode_t DynamicDataImpl::set_primitive_value<TK_STRING16>(
     return ret_value;
 }
 
+template<typename T, typename std::enable_if<std::is_integral<T>::value, bool>::type>
+bool DynamicDataImpl::check_new_discriminator_value(
+        const T& value)
+{
+    bool ret_value = false;
+
+    if (MEMBER_ID_INVALID != selected_union_member_) // There is a member selected by current discriminator.
+    {
+        traits<DynamicTypeMember>::ref_type selected_member;
+        enclosing_type_->get_member(selected_member, selected_union_member_);
+        auto sm_impl = traits<DynamicTypeMember>::narrow<DynamicTypeMemberImpl>(selected_member);
+
+        if (!sm_impl)
+        {
+            EPROSIMA_LOG_ERROR(DYNAMIC_DATA,
+                    "Null DynamicTypeMemberImpl pointer");
+            return false;
+        }
+
+        for (auto label : sm_impl->get_descriptor().label())
+        {
+            if (static_cast<int32_t>(value) == label)
+            {
+                ret_value = true;
+                break;
+            }
+        }
+    }
+
+    if (MEMBER_ID_INVALID == selected_union_member_ ||
+            (MEMBER_ID_INVALID == enclosing_type_->default_union_member() && !ret_value)) // It is selected the implicit default member.
+    {
+        ret_value = true;
+
+        if (enclosing_type_->default_value() != static_cast<int32_t>(value))
+        {
+            for (auto member : enclosing_type_->get_all_members_by_index())
+            {
+                auto m_impl = traits<DynamicTypeMember>::narrow<DynamicTypeMemberImpl>(member);
+
+                if (!m_impl)
+                {
+                    ret_value = false;
+                    continue;
+                }
+
+                for (auto label : m_impl->get_descriptor().label())
+                {
+                    if (static_cast<int32_t>(value) == label)
+                    {
+                        ret_value = false;
+                        break;
+                    }
+                }
+            }
+        }
+
+        if (ret_value)
+        {
+            selected_union_member_ = MEMBER_ID_INVALID;
+        }
+    }
+
+    return ret_value;
+}
+
 template<TypeKind TK>
 ReturnCode_t DynamicDataImpl::set_sequence_values(
         MemberId id,

src/cpp/fastdds/xtypes/dynamic_types/DynamicDataImpl.hpp

@@ -481,67 +481,7 @@ class DynamicDataImpl : public traits<DynamicData>::base_type
      */
     template<typename T, typename std::enable_if<std::is_integral<T>::value, bool>::type = true>
     bool check_new_discriminator_value(
-            const T& value)
-    {
-        bool ret_value = false;
-
-        if (MEMBER_ID_INVALID != selected_union_member_) // There is a member selected by current discriminator.
-        {
-            traits<DynamicTypeMember>::ref_type selected_member;
-            enclosing_type_->get_member(selected_member, selected_union_member_);
-            auto sm_impl = traits<DynamicTypeMember>::narrow<DynamicTypeMemberImpl>(selected_member);
-
-            if (!sm_impl)
-            {
-                return false;
-            }
-
-            for (auto label : sm_impl->get_descriptor().label())
-            {
-                if (static_cast<int32_t>(value) == label)
-                {
-                    ret_value = true;
-                    break;
-                }
-            }
-        }
-
-        if (MEMBER_ID_INVALID == selected_union_member_ ||
-                (MEMBER_ID_INVALID == enclosing_type_->default_union_member() && !ret_value)) // It is selected the implicit default member.
-        {
-            ret_value = true;
-
-            if (enclosing_type_->default_value() != static_cast<int32_t>(value))
-            {
-                for (auto member : enclosing_type_->get_all_members_by_index())
-                {
-                    auto m_impl = traits<DynamicTypeMember>::narrow<DynamicTypeMemberImpl>(member);
-
-                    if (!m_impl)
-                    {
-                        ret_value = false;
-                        continue;
-                    }
-
-                    for (auto label : m_impl->get_descriptor().label())
-                    {
-                        if (static_cast<int32_t>(value) == label)
-                        {
-                            ret_value = false;
-                            break;
-                        }
-                    }
-                }
-            }
-
-            if (ret_value)
-            {
-                selected_union_member_ = MEMBER_ID_INVALID;
-            }
-        }
-
-        return ret_value;
-    }
+            const T& value);
 
     template<typename T, typename std::enable_if<!std::is_integral<T>::value, bool>::type = true>
     bool check_new_discriminator_value(

src/cpp/fastdds/xtypes/dynamic_types/DynamicTypeBuilderImpl.cpp

@@ -61,7 +61,6 @@ DynamicTypeBuilderImpl::DynamicTypeBuilderImpl(
                                                                      members_.back())};
             if (!member_impl)
             {
-                assert(false);
                 EPROSIMA_LOG_ERROR(DYN_TYPES,
                         "Internal error: last member is not a DynamicTypeMemberImpl.");
             }