Refs #21358: Change null dereference compilation to test on alternatives build

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>

Author: Javier Gil Aviles

.github/workflows/reusable-ubuntu-ci.yml

@@ -60,6 +60,7 @@ on:
 
 env:
   security-cmake-flag: ${{ inputs.security == true && '-DSECURITY=ON' || '-DSECURITY=OFF' }}
+  colcon-build-default-cmake-args: '-DCMAKE_CXX_FLAGS="-Werror -Wall -Wextra -Wpedantic -Wunused-value -Woverloaded-virtual -Wsign-compare -Wcast-align -Wlogical-op -Wduplicated-cond -Wrestrict -Wpointer-arith -Wwrite-strings -Wunreachable-code"'
 defaults:
   run:
     shell: bash
@@ -73,8 +74,6 @@ jobs:
       matrix:
         cmake-build-type:
           - 'RelWithDebInfo'
-    env:
-      colcon-build-default-cmake-args: '-DCMAKE_CXX_FLAGS="-Werror -Wall -Wextra -Wpedantic -Wunused-value -Woverloaded-virtual -Wsign-compare -Wcast-align -Wlogical-op -Wduplicated-cond -Wrestrict -Wnull-dereference -Wpointer-arith -Wwrite-strings -Wunreachable-code"'
     steps:
       - name: Add ci-pending label if PR
         if: ${{ github.event_name == 'pull_request' && inputs.add-label == true }}
@@ -769,85 +768,100 @@ jobs:
           path: src/osrf_testing_tools_cpp
           ref: 1.4.0
 
-      - name: OSRF testing tools build
-        uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
-        with:
-          colcon_meta_file: ''
-          colcon_build_args: ${{ inputs.colcon-args }} --packages-select osrf_testing_tools_cpp
-          cmake_args: '-DBUILD_TESTING=OFF'
-          cmake_args_default: ''
-          cmake_build_type: ${{ matrix.cmake-build-type }}
-          workspace: ${{ github.workspace }}
-
-      - name: Profilling tests build
-        uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
-        with:
-          colcon_meta_file: ${{ github.workspace }}/src/fastdds/.github/workflows/config/fastdds_build.meta
-          colcon_build_args: ${{ inputs.colcon-args }} --packages-up-to fastdds
-          cmake_args: '-DPROFILING_TESTS=ON ${{ inputs.cmake-args }}'
-          cmake_args_default: ${{ env.colcon-build-default-cmake-args }}
-          cmake_build_type: ${{ matrix.cmake-build-type }}
-          workspace: ${{ github.workspace }}
-          workspace_dependencies: ${{ github.workspace }}/install
-
-      - name: Clean workspace - Profiling tests
-        run: |
-          cd ${{ github.workspace }}
-          rm -rf build install log src/osrf_testing_tools_cpp
-
-      - name: No security colcon build
-        continue-on-error: false
-        uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
-        with:
-          colcon_meta_file: ${{ github.workspace }}/src/fastdds/.github/workflows/config/fastdds_build.meta
-          colcon_build_args: ${{ inputs.colcon-args }}
-          cmake_args: '-DSECURITY=OFF ${{ inputs.cmake-args }}'
-          cmake_args_default: ${{ env.colcon-build-default-cmake-args }}
-          cmake_build_type: ${{ matrix.cmake-build-type }}
-          workspace: ${{ github.workspace }}
-
-      - name: Clean workspace - No security
-        run: |
-          cd ${{ github.workspace }}
-          rm -rf build install log
-
-      - name: No statistics colcon build
+    #   - name: OSRF testing tools build
+    #     uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
+    #     with:
+    #       colcon_meta_file: ''
+    #       colcon_build_args: ${{ inputs.colcon-args }} --packages-select osrf_testing_tools_cpp
+    #       cmake_args: '-DBUILD_TESTING=OFF'
+    #       cmake_args_default: ''
+    #       cmake_build_type: ${{ matrix.cmake-build-type }}
+    #       workspace: ${{ github.workspace }}
+
+    #   - name: Profilling tests build
+    #     uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
+    #     with:
+    #       colcon_meta_file: ${{ github.workspace }}/src/fastdds/.github/workflows/config/fastdds_build.meta
+    #       colcon_build_args: ${{ inputs.colcon-args }} --packages-up-to fastdds
+    #       cmake_args: '-DPROFILING_TESTS=ON ${{ inputs.cmake-args }}'
+    #       cmake_args_default: ${{ env.colcon-build-default-cmake-args }}
+    #       cmake_build_type: ${{ matrix.cmake-build-type }}
+    #       workspace: ${{ github.workspace }}
+    #       workspace_dependencies: ${{ github.workspace }}/install
+
+    #   - name: Clean workspace - Profiling tests
+    #     run: |
+    #       cd ${{ github.workspace }}
+    #       rm -rf build install log src/osrf_testing_tools_cpp
+
+    #   - name: No security colcon build
+    #     continue-on-error: false
+    #     uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
+    #     with:
+    #       colcon_meta_file: ${{ github.workspace }}/src/fastdds/.github/workflows/config/fastdds_build.meta
+    #       colcon_build_args: ${{ inputs.colcon-args }}
+    #       cmake_args: '-DSECURITY=OFF ${{ inputs.cmake-args }}'
+    #       cmake_args_default: ${{ env.colcon-build-default-cmake-args }}
+    #       cmake_build_type: ${{ matrix.cmake-build-type }}
+    #       workspace: ${{ github.workspace }}
+
+    #   - name: Clean workspace - No security
+    #     run: |
+    #       cd ${{ github.workspace }}
+    #       rm -rf build install log
+
+    #   - name: No statistics colcon build
+    #     uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
+    #     with:
+    #       colcon_meta_file: ${{ github.workspace }}/src/fastdds/.github/workflows/config/fastdds_build.meta
+    #       colcon_build_args: ${{ inputs.colcon-args }}
+    #       cmake_args: '-DFASTDDS_STATISTICS=OFF ${{ env.security-cmake-flag }} ${{ inputs.cmake-args }}'
+    #       cmake_args_default: ${{ env.colcon-build-default-cmake-args }}
+    #       cmake_build_type: ${{ matrix.cmake-build-type }}
+    #       workspace: ${{ github.workspace }}
+
+    #   - name: Clean workspace - No statistics
+    #     run: |
+    #       cd ${{ github.workspace }}
+    #       rm -rf build install log
+
+    #   # No .metas file, so FASTDDS_ENFORCE_LOG_INFO is set OFF by default. Missed important args are manually included
+    #   - name: No enforcing log info colcon build
+    #     uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
+    #     with:
+    #       colcon_meta_file: ''
+    #       colcon_build_args: ${{ inputs.colcon-args }}
+    #       cmake_args: '-DCOMPILE_EXAMPLES=ON ${{ env.security-cmake-flag }} ${{ inputs.cmake-args }}'
+    #       cmake_args_default: ${{ env.colcon-build-default-cmake-args }}
+    #       cmake_build_type: ${{ matrix.cmake-build-type }}
+    #       workspace: ${{ github.workspace }}
+
+    #   - name: Clean workspace - No enforce log info
+    #     run: |
+    #       cd ${{ github.workspace }}
+    #       rm -rf build install log
+
+    #   - name: No shared libs colcon build
+    #     uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
+    #     with:
+    #       colcon_meta_file: ${{ github.workspace }}/src/fastdds/.github/workflows/config/fastdds_build.meta
+    #       colcon_build_args: ${{ inputs.colcon-args }}
+    #       cmake_args: '-DBUILD_SHARED_LIBS=OFF ${{ env.security-cmake-flag }} ${{ inputs.cmake-args }}'
+    #       cmake_args_default: ${{ env.colcon-build-default-cmake-args }}
+    #       cmake_build_type: ${{ matrix.cmake-build-type }}
+    #       workspace: ${{ github.workspace }}
+
+    #   - name: Clean workspace - No shared libs
+    #     run: |
+    #       cd ${{ github.workspace }}
+    #       rm -rf build install log
+
+      - name: Null dereference colcon build
         uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
         with:
           colcon_meta_file: ${{ github.workspace }}/src/fastdds/.github/workflows/config/fastdds_build.meta
           colcon_build_args: ${{ inputs.colcon-args }}
-          cmake_args: '-DFASTDDS_STATISTICS=OFF ${{ env.security-cmake-flag }} ${{ inputs.cmake-args }}'
-          cmake_args_default: ${{ env.colcon-build-default-cmake-args }}
-          cmake_build_type: ${{ matrix.cmake-build-type }}
-          workspace: ${{ github.workspace }}
-
-      - name: Clean workspace - No statistics
-        run: |
-          cd ${{ github.workspace }}
-          rm -rf build install log
-
-      # No .metas file, so FASTDDS_ENFORCE_LOG_INFO is set OFF by default. Missed important args are manually included
-      - name: No enforcing log info colcon build
-        uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
-        with:
-          colcon_meta_file: ''
-          colcon_build_args: ${{ inputs.colcon-args }}
-          cmake_args: '-DCOMPILE_EXAMPLES=ON ${{ env.security-cmake-flag }} ${{ inputs.cmake-args }}'
-          cmake_args_default: ${{ env.colcon-build-default-cmake-args }}
-          cmake_build_type: ${{ matrix.cmake-build-type }}
-          workspace: ${{ github.workspace }}
-
-      - name: Clean workspace - No enforce log info
-        run: |
-          cd ${{ github.workspace }}
-          rm -rf build install log
-
-      - name: No shared libs colcon build
-        uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
-        with:
-          colcon_meta_file: ${{ github.workspace }}/src/fastdds/.github/workflows/config/fastdds_build.meta
-          colcon_build_args: ${{ inputs.colcon-args }}
-          cmake_args: '-DBUILD_SHARED_LIBS=OFF ${{ env.security-cmake-flag }} ${{ inputs.cmake-args }}'
+          cmake_args: '-DCMAKE_CXX_FLAGS="-Wnull-dereference" ${{ env.security-cmake-flag }} ${{ inputs.cmake-args }}'
           cmake_args_default: ${{ env.colcon-build-default-cmake-args }}
           cmake_build_type: ${{ matrix.cmake-build-type }}
           workspace: ${{ github.workspace }}
@@ -857,19 +871,19 @@ jobs:
           cd ${{ github.workspace }}
           rm -rf build install log
 
-      - name: Vanilla colcon build
-        uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
-        with:
-          cmake_build_type: ${{ matrix.cmake-build-type }}
-          workspace: ${{ github.workspace }}
-
-      - name: Clean workspace - Vanilla build
-        run: |
-          cd ${{ github.workspace }}
-          rm -rf build install log
-
-      - name: GCC latest colcon build
-        run: |
-          cd ${{ github.workspace }}/src/fastdds/.github/workflows/docker/ubuntu/alternative_builds
-          docker build -t fastdds_gcc_latest -f fastdds_gcc_latest.Dockerfile .
-          docker run --rm -v ${{ github.workspace }}:/root fastdds_gcc_latest
+    #   - name: Vanilla colcon build
+    #     uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
+    #     with:
+    #       cmake_build_type: ${{ matrix.cmake-build-type }}
+    #       workspace: ${{ github.workspace }}
+
+    #   - name: Clean workspace - Vanilla build
+    #     run: |
+    #       cd ${{ github.workspace }}
+    #       rm -rf build install log
+
+    #   - name: GCC latest colcon build
+    #     run: |
+    #       cd ${{ github.workspace }}/src/fastdds/.github/workflows/docker/ubuntu/alternative_builds
+    #       docker build -t fastdds_gcc_latest -f fastdds_gcc_latest.Dockerfile .
+    #       docker run --rm -v ${{ github.workspace }}:/root fastdds_gcc_latest

thirdparty/optionparser/optionparser/optionparser.h

@@ -770,23 +770,11 @@ class Option
    * @code for (Option* opt = options[FILE]; opt; opt = opt->next())
    *   fname = opt->arg; ... @endcode
    */
-#ifndef _MSC_VER
-  #pragma GCC diagnostic push
-  #pragma GCC diagnostic ignored "-Wnull-dereference"
-  #pragma clang diagnostic push
-  #pragma clang diagnostic ignored "-Wnull-dereference"
-#endif
-
   operator Option*()
   {
     return desc ? this : 0;
   }
 
-#ifndef _MSC_VER
-  #pragma clang diagnostic pop
-  #pragma GCC diagnostic pop
-#endif
-
   /**
    * @brief Creates a new Option that is a one-element linked list and has NULL
    * @ref desc, @ref name, @ref arg and @ref namelen.