Refs #23923: Create const copy

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

Author: cferreiragonz

include/fastdds/rtps/participant/RTPSParticipant.hpp

@@ -238,13 +238,23 @@ class FASTDDS_EXPORTED_API RTPSParticipant
      * instead to get a thread safe copy of the attributes.
      * @return RTPSParticipantAttributes reference.
      */
-    FASTDDS_TODO_BEFORE(4, 0, "Make this method return a copy and delete copy_attributes()");
+    FASTDDS_TODO_BEFORE(4, 0, "Refactor to differentiate mutable and constant objects and make getters thread safe");
     const RTPSParticipantAttributes& get_attributes() const;
 
+    /**
+     * @brief Get a const reference of the constant RTPSParticipantAttributes of this RTPSParticipantImpl.
+     * This method is thread safe because it returns a const reference to the internal attributes.
+     * @warning It must not be used to access mutable attributes as it could return outdated values.
+     * @return A const reference to the RTPSParticipantAttributes of this RTPSParticipantImpl.
+     */
+    FASTDDS_TODO_BEFORE(4, 0, "Refactor to differentiate mutable and constant objects and make getters thread safe");
+    const RTPSParticipantAttributes& get_const_attributes() const;
+
     /**
      * Get a copy of the current state of the RTPSParticipantParameters.
      * @return RTPSParticipantAttributes copy.
      */
+    FASTDDS_TODO_BEFORE(4, 0, "Refactor to differentiate mutable and constant objects and make getters thread safe");
     RTPSParticipantAttributes copy_attributes() const;
 
     /**

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupManager.cpp

@@ -127,7 +127,7 @@ bool TypeLookupManager::init(
 {
     participant_ = protocols->mp_participantImpl;
     builtin_protocols_ = protocols;
-    auto locators_allocations = participant_->copy_attributes().allocation.locators;
+    const auto& locators_allocations = participant_->get_const_attributes().allocation.locators;
 
     local_instance_name_ = get_instance_name(participant_->getGuid());
 

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.cpp

@@ -59,7 +59,7 @@ void TypeLookupReplyListener::start_reply_processor_thread()
                 };
         // Create and start the processing thread
         replies_processor_thread = eprosima::create_thread(thread_func,
-                        typelookup_manager_->participant_->copy_attributes().typelookup_service_thread,
+                        typelookup_manager_->participant_->get_const_attributes().typelookup_service_thread,
                         "dds.tls.replies.%u");
     }
 }

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupRequestListener.cpp

@@ -112,7 +112,7 @@ void TypeLookupRequestListener::start_request_processor_thread()
                 };
         // Create and start the processing thread
         request_processor_thread = eprosima::create_thread(thread_func,
-                        typelookup_manager_->participant_->copy_attributes().typelookup_service_thread,
+                        typelookup_manager_->participant_->get_const_attributes().typelookup_service_thread,
                         "dds.tls.requests.%u");
     }
 }

src/cpp/rtps/builtin/BuiltinProtocols.cpp

@@ -86,7 +86,7 @@ bool BuiltinProtocols::initBuiltinProtocols(
 
     filter_server_remote_locators(p_part->network_factory());
 
-    RTPSParticipantAllocationAttributes allocation = p_part->copy_attributes().allocation;
+    const RTPSParticipantAllocationAttributes& allocation = p_part->get_const_attributes().allocation;
 
     // PDP
     switch (m_att.discovery_config.discoveryProtocol)

src/cpp/rtps/builtin/discovery/endpoint/EDPSimple.cpp

@@ -755,7 +755,7 @@ void EDPSimple::assignRemoteEndpoints(
     const NetworkFactory& network = mp_RTPSParticipant->network_factory();
     uint32_t endp = pdata.m_available_builtin_endpoints;
     uint32_t auxendp;
-    bool use_multicast_locators = !mp_PDP->getRTPSParticipant()->copy_attributes().builtin.avoid_builtin_multicast ||
+    bool use_multicast_locators = !mp_PDP->getRTPSParticipant()->get_const_attributes().builtin.avoid_builtin_multicast ||
             pdata.metatraffic_locators.unicast.empty();
 
     auto temp_reader_proxy_data = get_temporary_reader_proxies_pool().get();

src/cpp/rtps/builtin/discovery/endpoint/EDPStatic.cpp

@@ -137,8 +137,8 @@ bool EDPStatic::initEDP(
     }
 
     // Check there is a Participant's property changing the exchange format.
-    auto properties = mp_RTPSParticipant->copy_attributes().properties.properties();
-    for (auto& property : properties)
+    const auto& properties = mp_RTPSParticipant->get_const_attributes().properties.properties();
+    for (const auto& property : properties)
     {
         if (0 == property.name().compare(exchange_format_property_name))
         {

src/cpp/rtps/builtin/discovery/participant/PDP.cpp

@@ -179,7 +179,7 @@ ParticipantProxyData* PDP::add_participant_proxy_data(
         {
             // Pool is empty but limit has not been reached, so we create a new entry.
             ++participant_proxies_number_;
-            ret_val = new ParticipantProxyData(mp_RTPSParticipant->copy_attributes().allocation);
+            ret_val = new ParticipantProxyData(mp_RTPSParticipant->get_const_attributes().allocation);
             if (participant_guid != mp_RTPSParticipant->getGuid())
             {
                 ret_val->lease_duration_event = new TimedEvent(mp_RTPSParticipant->getEventResource(),
@@ -487,8 +487,7 @@ bool PDP::initPDP(
 {
     EPROSIMA_LOG_INFO(RTPS_PDP, "Beginning");
     mp_RTPSParticipant = part;
-    m_discovery = mp_RTPSParticipant->copy_attributes().builtin;
-    initial_announcements_ = m_discovery.discovery_config.initial_announcements;
+    initial_announcements_ = mp_RTPSParticipant->get_const_attributes().builtin.discovery_config.initial_announcements;
     //CREATE ENDPOINTS
     if (!createPDPEndpoints())
     {
@@ -967,7 +966,7 @@ ReaderProxyData* PDP::addReaderProxyData(
                     // Pool is empty but limit has not been reached, so we create a new entry.
                     ++reader_proxies_number_;
 
-                    auto allocations = mp_RTPSParticipant->copy_attributes().allocation;
+                    const auto& allocations = mp_RTPSParticipant->get_const_attributes().allocation;
 
                     ret_val = new ReaderProxyData(
                         allocations.locators.max_unicast_locators,
@@ -1055,7 +1054,7 @@ WriterProxyData* PDP::addWriterProxyData(
                     // Pool is empty but limit has not been reached, so we create a new entry.
                     ++writer_proxies_number_;
 
-                    auto allocations = mp_RTPSParticipant->copy_attributes().allocation;
+                    const auto& allocations = mp_RTPSParticipant->get_const_attributes().allocation;
 
                     ret_val = new WriterProxyData(
                         allocations.locators.max_unicast_locators,
@@ -1518,7 +1517,7 @@ void PDP::resend_ininitial_announcements()
 void PDP::set_external_participant_properties_(
         ParticipantProxyData* participant_data)
 {
-    auto part_attributes = mp_RTPSParticipant->copy_attributes();
+    const RTPSParticipantAttributes& part_attributes = mp_RTPSParticipant->get_const_attributes();
 
     // For each property add it if it should be sent (it is propagated)
     for (auto const& property : part_attributes.properties.properties())
@@ -1588,8 +1587,6 @@ static void set_builtin_endpoint_locators(
         const PDP* pdp,
         const BuiltinProtocols* builtin)
 {
-    RTPSParticipantAttributes pattr = pdp->getRTPSParticipant()->copy_attributes();
-
     auto part_data = pdp->getLocalParticipantProxyData();
     if (nullptr == part_data)
     {
@@ -1615,14 +1612,14 @@ static void set_builtin_endpoint_locators(
 
     // External locators are always taken from the same place
     endpoint.external_unicast_locators = pdp->builtin_attributes().metatraffic_external_unicast_locators;
-    endpoint.ignore_non_matching_locators = pattr.ignore_non_matching_locators;
+    endpoint.ignore_non_matching_locators = pdp->getRTPSParticipant()->get_const_attributes().ignore_non_matching_locators;
 }
 
 ReaderAttributes PDP::create_builtin_reader_attributes()
 {
     ReaderAttributes attributes;
 
-    RTPSParticipantAttributes pattr = getRTPSParticipant()->copy_attributes();
+    const RTPSParticipantAttributes& pattr = getRTPSParticipant()->get_const_attributes();
     set_builtin_matched_allocation(attributes.matched_writers_allocation, pattr);
 
     // Builtin endpoints are always reliable, transient local, keyed topics
@@ -1646,7 +1643,7 @@ WriterAttributes PDP::create_builtin_writer_attributes()
 {
     WriterAttributes attributes;
 
-    RTPSParticipantAttributes pattr = getRTPSParticipant()->copy_attributes();
+    const RTPSParticipantAttributes& pattr = getRTPSParticipant()->get_const_attributes();
     set_builtin_matched_allocation(attributes.matched_readers_allocation, pattr);
 
     // Builtin endpoints are always reliable, transient local, keyed topics

src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp

@@ -104,7 +104,7 @@ void PDPClient::initializeParticipantProxyData(
 {
     PDP::initializeParticipantProxyData(participant_data); // TODO: Remember that the PDP version USES security
 
-    auto discovery_config = getRTPSParticipant()->copy_attributes().builtin.discovery_config;
+    const auto& discovery_config = getRTPSParticipant()->get_const_attributes().builtin.discovery_config;
 
     if ((DiscoveryProtocol::CLIENT != discovery_config.discoveryProtocol) &&
             (DiscoveryProtocol::SUPER_CLIENT != discovery_config.discoveryProtocol))

src/cpp/rtps/builtin/discovery/participant/PDPListener.cpp

@@ -49,7 +49,7 @@ namespace rtps {
 PDPListener::PDPListener(
         PDP* parent)
     : parent_pdp_(parent)
-    , temp_participant_data_(parent->getRTPSParticipant()->copy_attributes().allocation)
+    , temp_participant_data_(parent->getRTPSParticipant()->get_const_attributes().allocation)
 {
 }