Refs #21358: Delate assert(false) and add log error

Javier Gil Aviles · Javier Gil Aviles · commit d123b9babb84 · 2025-07-02T08:18:10.000+02:00
Signed-off-by: Javier Gil Aviles &lt;javiergil@eprosima.com&gt;
diff --git a/src/cpp/fastdds/xtypes/dynamic_types/DynamicDataImpl.hpp b/src/cpp/fastdds/xtypes/dynamic_types/DynamicDataImpl.hpp
@@ -493,6 +493,8 @@ class DynamicDataImpl : public traits<DynamicData>::base_type
 
             if (!sm_impl)
             {
+                EPROSIMA_LOG_ERROR(DYNAMIC_DATA,
+                        "Null DynamicTypeMemberImpl pointer for member id " << selected_union_member_);
                 return false;
             }
 
diff --git a/src/cpp/fastdds/xtypes/dynamic_types/DynamicTypeBuilderImpl.cpp b/src/cpp/fastdds/xtypes/dynamic_types/DynamicTypeBuilderImpl.cpp
@@ -61,7 +61,6 @@ DynamicTypeBuilderImpl::DynamicTypeBuilderImpl(
                                                                      members_.back())};
             if (!member_impl)
             {
-                assert(false);
                 EPROSIMA_LOG_ERROR(DYN_TYPES,
                         "Internal error: last member is not a DynamicTypeMemberImpl.");
             }

Original file line number	Diff line number	Diff line change
`@@ -493,6 +493,8 @@ class DynamicDataImpl : public traits<DynamicData>::base_type`
`493`	`493`
`494`	`494`	`if (!sm_impl)`
`495`	`495`	`{`
	`496`	`+ EPROSIMA_LOG_ERROR(DYNAMIC_DATA,`
	`497`	`+ "Null DynamicTypeMemberImpl pointer for member id " << selected_union_member_);`
`496`	`498`	`return false;`
`497`	`499`	`}`
`498`	`500`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@ DynamicTypeBuilderImpl::DynamicTypeBuilderImpl(`
`61`	`61`	`members_.back())};`
`62`	`62`	`if (!member_impl)`
`63`	`63`	`{`
`64`		`- assert(false);`
`65`	`64`	`EPROSIMA_LOG_ERROR(DYN_TYPES,`
`66`	`65`	`"Internal error: last member is not a DynamicTypeMemberImpl.");`
`67`	`66`	`}`