Skip to content

Commit fae8d8f

Browse files
author
Javier Gil Aviles
committed
Refs #21358: Assert correctiosn fro tests
Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
1 parent c87e310 commit fae8d8f

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

.github/workflows/reusable-ubuntu-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -860,7 +860,7 @@ jobs:
860860
uses: eProsima/eProsima-CI/multiplatform/colcon_build@v0
861861
with:
862862
colcon_meta_file: ${{ github.workspace }}/src/fastdds/.github/workflows/config/fastdds_build.meta
863-
colcon_build_args: ${{ inputs.colcon-args }}
863+
colcon_build_args: '-DBUILD_TESTING=OFF ${{ inputs.colcon-args }} --packages-select fastdds'
864864
cmake_args: '-DCMAKE_CXX_FLAGS="-Wnull-dereference" ${{ env.security-cmake-flag }} ${{ inputs.cmake-args }}'
865865
cmake_args_default: ${{ env.colcon-build-default-cmake-args }}
866866
cmake_build_type: ${{ matrix.cmake-build-type }}

src/cpp/fastdds/xtypes/dynamic_types/DynamicTypeBuilderImpl.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,9 @@ DynamicTypeBuilderImpl::DynamicTypeBuilderImpl(
6161
members_.back())};
6262
if (!member_impl)
6363
{
64+
assert(false);
6465
EPROSIMA_LOG_ERROR(DYN_TYPES,
65-
"Internal error: last member is not a DynamicTypeMemberImpl");
66+
"Internal error: last member is not a DynamicTypeMemberImpl.");
6667
}
6768
else
6869
{

src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -577,10 +577,15 @@ void PDPSimple::unmatch_pdp_remote_endpoints(
577577
auto endpoints = dynamic_cast<fastdds::rtps::SimplePDPEndpoints*>(builtin_endpoints_.get());
578578
if (nullptr == endpoints)
579579
{
580+
assert(false);
580581
EPROSIMA_LOG_ERROR(RTPS_PDP,
581582
"unmatch_pdp_remote_endpoints(): builtin_endpoints_ is null or wrong type");
582583
return;
583584
}
585+
else
586+
{
587+
assert(true);
588+
}
584589

585590
guid.entityId = c_EntityId_SPDPWriter;
586591
if (!endpoints->reader.reader_)

0 commit comments

Comments
 (0)