Remove deprecated windows-2019 runner (#211) (#213)

* Remove deprecated windows-2019 runner (#211)

* Remove deprecated windows-2019 runner

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Add vs-toolset matrix

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 653bb92)

# Conflicts:
#	.github/workflows/nightly-windows-ci.yml
#	.github/workflows/windows-ci.yml
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Resolve backport conflicts

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Co-authored-by: Raul Sanchez-Mateos Lizano <raulsml18@gmail.com>
Co-authored-by: Raul Sanchez-Mateos <raul@eprosima.com>

Author: mergify[bot]

.github/workflows/reusable-windows-ci.yml

@@ -6,7 +6,7 @@ on:
       os-version:
         description: 'The OS image for the workflow'
         required: false
-        default: 'windows-2019'
+        default: 'windows-2022'
         type: string
       vs-toolset:
         description: 'The VS toolset to use for the build'

.github/workflows/windows-ci.yml

@@ -6,12 +6,7 @@ on:
       os-version:
         description: 'OS version to run the workflow'
         required: false
-        default: 'windows-2019'
-        type: string
-      vs-toolset:
-        description: 'The VS toolset to use for the build'
-        required: false
-        default: 'v142'
+        default: 'windows-2022'
         type: string
       colcon-args:
         description: 'Extra arguments for colcon cli'
@@ -52,15 +47,15 @@ jobs:
       fail-fast: false
       matrix:
         vs-toolset:
-          - 'v141'
           - 'v142'
+          - 'v143'
     if: ${{ !(github.event_name == 'pull_request') || !contains(github.event.pull_request.labels.*.name, 'conflicts') }}
     uses: ./.github/workflows/reusable-windows-ci.yml
     with:
       # It would be desirable to have a matrix of ubuntu OS for this job, but due to the issue opened in this ticket:
       # https://github.com/orgs/community/discussions/128118 , it has been set as a single OS job.
-      os-version: ${{ inputs.os-version || 'windows-2019' }}
-      vs-toolset: ${{ inputs.vs-toolset || matrix.vs-toolset }}
+      os-version: ${{ inputs.os-version || 'windows-2022' }}
+      vs-toolset: ${{ matrix.vs-toolset }}
       label: 'windows-${{ matrix.vs-toolset }}-ci-2.14.x'
       colcon-args: ${{ inputs.colcon-args }}
       cmake-args: ${{ inputs.cmake-args }}