Skip to content

Implement tests for some of the sub-functions of perform_atmospheric_chemistry_and_microphysics() #412

@mjschmidt271

Description

@mjschmidt271

The following functions that are called by perform_atmospheric_chemistry_and_microphysics() do not yet have tests.

  • compute_o3_column_density()
    • Only calls utility functions and does very low-level computations
      • set_ub_col() is tested
      • setcol() is not tested, though quite simple
      void setcol(const ThreadTeam &team, const Real o3_col_deltas[mam4::nlev + 1],
          ColumnView &o3_col_dens) {
        // we can probably accelerate this with a parallel_scan, but let's just do
        // a simple loop for now
        constexpr int nlev = mam4::nlev;
        Kokkos::single(Kokkos::PerTeam(team), [=]() {
          o3_col_dens(0) = 0.5 * (o3_col_deltas[0] + o3_col_deltas[1]);
          for (int k = 1; k < nlev; ++k) {
            o3_col_dens(k) =
                o3_col_dens(k - 1) + 0.5 * (o3_col_deltas[k] + o3_col_deltas[k + 1]);
          }
        });
      }
    • Does not appear to have validation data
  • gas_phase_chemistry()
    • Not tested, but all functions within are

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions