Cleanup

Author: mpiannucci

icechunk/src/storage/object_store.rs

@@ -14,12 +14,9 @@ use futures::{
     stream::{self, BoxStream},
 };
 use object_store::{
-    Attribute, AttributeValue, Attributes, , CredentialProvider,
-    GetOptions, ObjectMeta, ObjectStore, PutMode, PutOptions, PutPayload,
-    Attribute, AttributeValue, Attributes, BackoffConfig, ClientConfigKey, 
-    CredentialProvider, GetOptions, ObjectMeta, ObjectStore, PutMode, 
-    PutOptions, PutPayload, RetryConfig, StaticCredentialProvider, 
-    UpdateVersion,
+    Attribute, AttributeValue, Attributes, BackoffConfig, ClientConfigKey,
+    CredentialProvider, GetOptions, ObjectMeta, ObjectStore, PutMode, PutOptions,
+    PutPayload, RetryConfig, StaticCredentialProvider, UpdateVersion,
     aws::AmazonS3Builder,
     azure::{AzureConfigKey, MicrosoftAzureBuilder},
     gcp::{GcpCredential, GoogleCloudStorageBuilder, GoogleConfigKey},
@@ -786,7 +783,10 @@ impl fmt::Display for HttpObjectStoreBackend {
 
 #[typetag::serde(name = "http_object_store_provider")]
 impl ObjectStoreBackend for HttpObjectStoreBackend {
-    fn mk_object_store(&self) -> Result<Arc<dyn ObjectStore>, StorageError> {
+    fn mk_object_store(
+        &self,
+        _settings: &Settings,
+    ) -> Result<Arc<dyn ObjectStore>, StorageError> {
         let builder = HttpBuilder::new().with_url(&self.url);
 
         // Add options

icechunk/src/virtual_chunks.rs

@@ -552,10 +552,11 @@ impl ObjectStoreFetcher {
             .collect();
         let backend =
             HttpObjectStoreBackend { url: url.to_string(), config: Some(config) };
+        let settings = storage::Settings::default();
         let client = backend
-            .mk_object_store()
+            .mk_object_store(&settings)
             .map_err(|e| VirtualReferenceErrorKind::OtherError(Box::new(e)))?;
-        Ok(ObjectStoreFetcher { client, settings: storage::Settings::default() })
+        Ok(ObjectStoreFetcher { client, settings })
     }
 
     pub async fn new_gcs(