CI: pep440 compliant dev version for nightly wheels (#1229)

* CI: pep440 compliant dev version for nightly wheels

* only update version when necessary

* clearer naming

Author: ianhi

.github/workflows/python-ci.yaml

@@ -7,6 +7,17 @@ name: Python CI and library release
 
 on:
   workflow_dispatch:
+    inputs:
+      pypi_release:
+        description: 'Make a PyPI release'
+        required: true
+        default: false
+        type: boolean
+      use_git_version:
+        description: 'Use git-based version for nightly builds'
+        required: true
+        default: true
+        type: boolean
   schedule:
     # run every day at 4am
     - cron: '0 4 * * *'
@@ -23,8 +34,47 @@ defaults:
     working-directory: ./icechunk-python
 
 jobs:
+  version:
+    name: Generate dynamic version
+    runs-on: ubuntu-latest
+    outputs:
+      version: ${{ steps.version.outputs.version }}
+    steps:
+      - uses: actions/checkout@v5
+        with:
+          fetch-depth: 0  # Need full history for git describe
+
+      - name: Generate version
+        id: version
+        run: |
+          if [[ "${{ github.event_name }}" == "schedule" ]] || [[ "${{ inputs.use_git_version }}" == "true" ]]; then
+            # For nightly builds, use component-based git describe approach
+
+            # Verify we have proper git tags
+            if ! git describe --tags --match "v*" >/dev/null 2>&1; then
+              echo "❌ ERROR: No version tags found. Please create a tag like 'v1.0.0' first."
+              exit 1
+            fi
+
+            # Get components from git (much simpler than parsing)
+            TAG=$(git describe --tags --match 'v*' --abbrev=0 | sed 's/^v//')
+            DISTANCE=$(git rev-list $(git describe --tags --match 'v*' --abbrev=0)..HEAD --count)
+            HASH=$(git rev-parse --short HEAD)
+
+            # Build PEP 440 compliant version (always use .dev format)
+            VERSION="${TAG}.dev${DISTANCE}+g${HASH}"
+            echo "Git version: ${TAG}, distance: ${DISTANCE}, hash: ${HASH}"
+            echo "Using git-based version: $VERSION"
+          else
+            # For regular releases, use version from Cargo.toml
+            VERSION=$(grep '^version = ' icechunk-python/Cargo.toml | sed 's/version = "\(.*\)"/\1/')
+            echo "Using Cargo.toml version: $VERSION"
+          fi
+          echo "version=$VERSION" >> $GITHUB_OUTPUT
+
   linux:
     runs-on: ${{ matrix.platform.runner }}
+    needs: version
     strategy:
       matrix:
         platform:
@@ -56,6 +106,10 @@ jobs:
       - uses: actions/setup-python@v6
         with:
           python-version: '3.11'
+      - name: Update version in Cargo.toml
+        if: ${{ github.event_name == 'schedule' || inputs.use_git_version == true }}
+        run: |
+          sed -i 's/^version = ".*"/version = "${{ needs.version.outputs.version }}"/' Cargo.toml
       - name: Build wheels
         uses: PyO3/maturin-action@v1
         with:
@@ -71,6 +125,7 @@ jobs:
 
   musllinux:
     runs-on: ${{ matrix.platform.runner }}
+    needs: version
     strategy:
       matrix:
         platform:
@@ -87,6 +142,10 @@ jobs:
       - uses: actions/setup-python@v6
         with:
           python-version: 3.x
+      - name: Update version in Cargo.toml
+        if: ${{ github.event_name == 'schedule' || inputs.use_git_version == true }}
+        run: |
+          sed -i 's/^version = ".*"/version = "${{ needs.version.outputs.version }}"/' Cargo.toml
       - name: Build wheels
         uses: PyO3/maturin-action@v1
         with:
@@ -102,6 +161,7 @@ jobs:
 
   windows:
     runs-on: ${{ matrix.platform.runner }}
+    needs: version
     strategy:
       matrix:
         platform:
@@ -115,6 +175,11 @@ jobs:
         with:
           python-version: 3.x
           architecture: ${{ matrix.platform.target }}
+      - name: Update version in Cargo.toml
+        if: ${{ github.event_name == 'schedule' || inputs.use_git_version == true }}
+        run: |
+          (Get-Content Cargo.toml) -replace '^version = ".*"', 'version = "${{ needs.version.outputs.version }}"' | Set-Content Cargo.toml
+        shell: powershell
       - name: Build wheels
         uses: PyO3/maturin-action@v1
         with:
@@ -129,6 +194,7 @@ jobs:
 
   macos:
     runs-on: ${{ matrix.platform.runner }}
+    needs: version
     strategy:
       matrix:
         platform:
@@ -141,6 +207,10 @@ jobs:
       - uses: actions/setup-python@v6
         with:
           python-version: 3.x
+      - name: Update version in Cargo.toml
+        if: ${{ github.event_name == 'schedule' || inputs.use_git_version == true }}
+        run: |
+          sed -i '' 's/^version = ".*"/version = "${{ needs.version.outputs.version }}"/' Cargo.toml
       - name: Build wheels
         uses: PyO3/maturin-action@v1
         with:
@@ -155,8 +225,13 @@ jobs:
 
   sdist:
     runs-on: ubuntu-latest
+    needs: version
     steps:
       - uses: actions/checkout@v5
+      - name: Update version in Cargo.toml
+        if: ${{ github.event_name == 'schedule' || inputs.use_git_version == true }}
+        run: |
+          sed -i 's/^version = ".*"/version = "${{ needs.version.outputs.version }}"/' Cargo.toml
       - name: Build sdist
         uses: PyO3/maturin-action@v1
         with:
@@ -174,7 +249,7 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       id-token: write # IMPORTANT: this permission is mandatory for trusted publishing
-    if: ${{ github.event_name == 'workflow_dispatch' }}
+    if: ${{ github.event_name == 'workflow_dispatch' && inputs.pypi_release }}
     needs: [linux, musllinux, windows, macos, sdist]
     steps:
       - uses: actions/download-artifact@v5