doc: fix version picker duplication (#1173)

* doc: fix version picker duplication

* pin cargo deny

0.18.4 uses a version of rust greater than we currently use, causing
errors.

Author: ianhi

.github/workflows/publish-rust-library.yml

@@ -7,7 +7,10 @@ env:
   RUST_BACKTRACE: short
   RUSTFLAGS: "-D warnings -W unreachable-pub -W bare-trait-objects"
   RUSTUP_MAX_RETRIES: 10
+  # update RUST_CHANNEL and CARGO_DENY in sync
+  # version 0.18.4 of cargo-deny requires rustc 1.88.0 breaks our current version on 1.87
   RUST_CHANNEL: '1.87.0'
+  CARGO_DENY_VERSION: '0.18.3'
 
 on:
   workflow_dispatch:
@@ -48,7 +51,7 @@ jobs:
           key: ${{ env.RUST_CHANNEL }}
 
       - name: Install cargo-deny
-        run: cargo install --locked cargo-deny
+        run: cargo install --locked cargo-deny --version ${{ env.CARGO_DENY_VERSION }}
 
       - name: Check
         if: github.event_name == 'push'

.github/workflows/rust-ci.yaml

@@ -25,7 +25,10 @@ env:
   RUST_BACKTRACE: short
   RUSTFLAGS: "-D warnings -W unreachable-pub -W bare-trait-objects"
   RUSTUP_MAX_RETRIES: 10
+  # update RUST_CHANNEL and CARGO_DENY in sync
+  # version 0.18.4 of cargo-deny requires rustc 1.88.0 breaks our current version on 1.87
   RUST_CHANNEL: '1.87.0'
+  CARGO_DENY_VERSION: '0.18.3'
 
 jobs:
   rust-ci:
@@ -115,7 +118,7 @@ jobs:
 
       - name: Install cargo-deny
         if: matrix.os == 'ubuntu-latest' || matrix.os == 'ubuntu-24.04-arm'
-        run: cargo install --locked cargo-deny
+        run: cargo install --locked cargo-deny --version ${{ env.CARGO_DENY_VERSION }}
 
       # Basic checks that run for all pull requests (including external)
       - name: Check formatting

docs/docs/scripts/readthedocs.js

@@ -20,5 +20,11 @@ ${ config.versions.active.map(
 </ul>
 </div>`;
 
-document.querySelector(".md-header__topic").insertAdjacentHTML("beforeend", versioning);
-});
+    // Check if we already added versions and remove them if so
+    // from https://github.com/readthedocs/readthedocs.org/pull/12142
+    const currentVersions = document.querySelector(".md-version");
+    if (currentVersions !== null) {
+      currentVersions.remove();
+    }
+    document.querySelector(".md-header__topic").insertAdjacentHTML("beforeend", versioning);
+  });

docs/mkdocs.yml

@@ -46,11 +46,9 @@ theme:
         name: Switch to light mode
 
   features:
-    # instant causes duplicated version dropdown
-    # see: https://github.com/readthedocs/readthedocs.org/issues/12032
-    # - navigation.instant
-    # - navigation.instant.prefetch
-    # - navigation.instant.progress
+    - navigation.instant
+    - navigation.instant.prefetch
+    - navigation.instant.progress
     - navigation.tracking
     - navigation.indexes
     - navigation.footer