Skip to content

Commit 67be188

Browse files
fix(ci): only enable sccache: s3 on maturin build jobs
runs-on/action sets RUSTC_WRAPPER=sccache when sccache: s3 is enabled, but doesn't install the sccache binary. This breaks any cargo command in jobs without maturin (which installs its own sccache). Restrict sccache: s3 to the 4 maturin wheel build jobs only. Co-authored-by: Claude <noreply@anthropic.com>
1 parent db8f36a commit 67be188

File tree

10 files changed

+0
-52
lines changed

10 files changed

+0
-52
lines changed

.github/workflows/code-quality.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ jobs:
3030

3131
steps:
3232
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
33-
with:
34-
sccache: s3
3533
- name: Checkout repository
3634
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
3735
with:

.github/workflows/codespell.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ jobs:
1919

2020
steps:
2121
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
22-
with:
23-
sccache: s3
2422
- name: Checkout
2523
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
2624
- name: Annotate locations with typos

.github/workflows/dependency-check.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ jobs:
3333

3434
steps:
3535
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
36-
with:
37-
sccache: s3
3836
- name: Checkout repository
3937
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
4038
with:

.github/workflows/detect-unused-dependencies.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ jobs:
88
runs-on: runs-on=${{ github.run_id }}/runner=2cpu-linux-x64/extras=s3-cache
99
steps:
1010
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
11-
with:
12-
sccache: s3
1311
- name: Checkout
1412
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
1513
- name: Machete

.github/workflows/js-ci.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@ jobs:
7272
runs-on: ${{ matrix.settings.host }}
7373
steps:
7474
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
75-
with:
76-
sccache: s3
7775
- uses: actions/checkout@v6
7876
- name: Setup node
7977
uses: actions/setup-node@v6
@@ -187,8 +185,6 @@ jobs:
187185
runs-on: runs-on=${{ github.run_id }}/runner=4cpu-linux-x64/extras=s3-cache
188186
steps:
189187
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
190-
with:
191-
sccache: s3
192188
- uses: actions/checkout@v6
193189
- name: Setup node
194190
uses: actions/setup-node@v6
@@ -219,8 +215,6 @@ jobs:
219215
working-directory: ./icechunk-js
220216
steps:
221217
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
222-
with:
223-
sccache: s3
224218
- uses: actions/checkout@v6
225219
- name: Setup node
226220
uses: actions/setup-node@v6
@@ -261,8 +255,6 @@ jobs:
261255
- test-wasi
262256
steps:
263257
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
264-
with:
265-
sccache: s3
266258
- uses: actions/checkout@v6
267259
- name: Setup node
268260
uses: actions/setup-node@v6

.github/workflows/publish-rust-library.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ jobs:
2121

2222
steps:
2323
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
24-
with:
25-
sccache: s3
2624
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
2725

2826
- name: Stand up docker services

.github/workflows/python-check.yaml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@ jobs:
6868
zarr: "latest-release"
6969
steps:
7070
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
71-
with:
72-
sccache: s3
7371
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
7472
- name: Stand up RustFS
7573
run: |
@@ -170,8 +168,6 @@ jobs:
170168
needs: [build-wheels-free-threaded]
171169
steps:
172170
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
173-
with:
174-
sccache: s3
175171
- uses: actions/checkout@v6
176172
- name: Stand up RustFS
177173
run: |
@@ -230,8 +226,6 @@ jobs:
230226
shard-id: [0, 1, 2]
231227
steps:
232228
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
233-
with:
234-
sccache: s3
235229
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
236230

237231
- name: Download wheels
@@ -297,8 +291,6 @@ jobs:
297291
working-directory: .
298292
steps:
299293
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
300-
with:
301-
sccache: s3
302294
- name: Verify all shards passed
303295
run: |
304296
if [ "${{ needs.test-hypothesis-shard.result }}" != "success" ]; then
@@ -311,8 +303,6 @@ jobs:
311303
needs: [build-wheels]
312304
steps:
313305
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
314-
with:
315-
sccache: s3
316306
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
317307

318308
- name: Download wheels
@@ -361,8 +351,6 @@ jobs:
361351
zarr: "latest-release"
362352
steps:
363353
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
364-
with:
365-
sccache: s3
366354
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
367355
with:
368356
path: "icechunk"
@@ -456,8 +444,6 @@ jobs:
456444
needs: [build-wheels]
457445
steps:
458446
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
459-
with:
460-
sccache: s3
461447
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
462448

463449
- name: Download wheels
@@ -488,8 +474,6 @@ jobs:
488474
runs-on: runs-on=${{ github.run_id }}/runner=2cpu-linux-x64/extras=s3-cache
489475
steps:
490476
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
491-
with:
492-
sccache: s3
493477
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
494478
with:
495479
path: "icechunk"

.github/workflows/python-ci.yaml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ jobs:
6363
# If updating the logic, ensure BOTH steps are updated identically.
6464
steps:
6565
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
66-
with:
67-
sccache: s3
6866
# Checkout main branch (skip if only building support/v1.x)
6967
- name: Checkout main
7068
if: ${{ github.event_name == 'schedule' || inputs.branch != 'support/v1.x' }}
@@ -149,8 +147,6 @@ jobs:
149147
manylinux: 2_28
150148
steps:
151149
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
152-
with:
153-
sccache: s3
154150
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
155151
with:
156152
ref: ${{ matrix.branch }}
@@ -206,8 +202,6 @@ jobs:
206202
target: armv7
207203
steps:
208204
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
209-
with:
210-
sccache: s3
211205
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
212206
with:
213207
ref: ${{ matrix.branch }}
@@ -319,8 +313,6 @@ jobs:
319313
branch: ${{ github.event_name == 'schedule' && fromJSON('["main", "support/v1.x"]') || fromJSON(format('["{0}"]', inputs.branch)) }}
320314
steps:
321315
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
322-
with:
323-
sccache: s3
324316
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
325317
with:
326318
ref: ${{ matrix.branch }}
@@ -353,8 +345,6 @@ jobs:
353345
needs: [linux, musllinux, windows, macos, sdist]
354346
steps:
355347
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
356-
with:
357-
sccache: s3
358348
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
359349
- name: Publish to PyPI
360350
uses: PyO3/maturin-action@db323e2cf5679b7feb8bcb561a36b27a0bc19e79 # v1
@@ -369,8 +359,6 @@ jobs:
369359
needs: [linux, musllinux, windows, macos, sdist]
370360
steps:
371361
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
372-
with:
373-
sccache: s3
374362
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
375363
with:
376364
path: dist

.github/workflows/rust-ci.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ jobs:
4848

4949
steps:
5050
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
51-
with:
52-
sccache: s3
5351
- name: Checkout repository
5452
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
5553
with:
@@ -203,8 +201,6 @@ jobs:
203201

204202
steps:
205203
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
206-
with:
207-
sccache: s3
208204
- name: Checkout repository
209205
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
210206
with:

.github/workflows/rust-upstream.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ jobs:
4040
}}
4141
steps:
4242
- uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2
43-
with:
44-
sccache: s3
4543
- name: Checkout icechunk
4644
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
4745
with:

0 commit comments

Comments
 (0)