Fix serialization of GCS session with bearer token

Author: paraseba

icechunk/src/config.rs

@@ -528,8 +528,6 @@ pub enum GcsStaticCredentials {
 }
 
 #[derive(Clone, Debug, Deserialize, Serialize, PartialEq, Eq)]
-#[serde(tag = "gcs_bearer_credential_type")]
-#[serde(rename_all = "snake_case")]
 pub struct GcsBearerCredential {
     pub bearer: String,
     pub expires_after: Option<DateTime<Utc>>,

icechunk/src/storage/mod.rs

@@ -950,6 +950,8 @@ mod tests {
 
     use std::{collections::HashSet, fs::File, io::Write, path::PathBuf};
 
+    use crate::config::{GcsBearerCredential, GcsStaticCredentials};
+
     use super::*;
     use icechunk_macros::tokio_test;
     use proptest::prelude::*;
@@ -971,6 +973,27 @@ mod tests {
         assert!(s.root_is_clean().await.unwrap());
     }
 
+    #[tokio_test]
+    /// Regression test: we can deserialize a GCS credential with token
+    async fn test_gcs_session_serialization() {
+        let storage = new_gcs_storage(
+            "bucket".to_string(),
+            Some("prefix".to_string()),
+            Some(GcsCredentials::Static(GcsStaticCredentials::BearerToken(
+                GcsBearerCredential {
+                    bearer: "the token".to_string(),
+                    expires_after: None,
+                },
+            ))),
+            None,
+        )
+        .await
+        .unwrap();
+        let bytes = rmp_serde::to_vec(&storage).unwrap();
+        let dese: Result<Arc<dyn Storage>, _> = rmp_serde::from_slice(&bytes);
+        assert!(dese.is_ok())
+    }
+
     proptest! {
         #![proptest_config(ProptestConfig {
             cases: 999, .. ProptestConfig::default()