Out-of-date encodings

[AljoschaMeyer]

LCMUX: Different tags for the different kinds of frames, and SendChannelFrame uses a simplified encoding.

Implemented in e0504c0

[AljoschaMeyer]

EntryRelativeEntry: timediff tag now stored in bits 3 and 4, remaining three bits are for payload_length. Order of the fields is also changed.

[AljoschaMeyer]

EntryInNamespace3dRange: timediff tag now stored in bits 3 and 4, remaining three bits are for payload_length.

[AljoschaMeyer]

The relative entry encoding in the current sideloading implementation is also outdated iirc. I'll tackle this one - eventually (at the latest as part of the test vector milestone).

[AljoschaMeyer]

The absolute EnumerationCapability encoding: moved the 8-bit tag for the delegations count from the start of the encoding directly before the delegation count encoding.

[AljoschaMeyer]

Collecting things we should/need change about our current encoding implementations here. Going through the encodings page and comparing to our actual code. Have compared up to and including EncodeMcCapability.

Issues:

✅ EncodeEntryInNamespace3dRange

• ✅ Our implementation has canonic decoding, but Willow doesn't use that any longer. fixed on test_vectors branch
• ✅ In our implementation, both the time_diff variable and the third header bit look outdated. I might be wrong about this. But there are no explicit checks for open ranges. This might be done in u64::from(&out.times().end). If so, then that code feels somewhat too clever =S code appears to be correct, I'm leaving it in its too-clever state due to time constraints

✅ EncodeAreaInArea

• ✅ time diffs might be outdated? (same as above in EncodeEntryInNamespace3dRange) looking at the decoding code, seems to be correct
• ✅ self.path().relative_encode(consumer, r.path()).await?; must use encode_path_extends_path instead and move to the end of the encoding fixed on test_vectors branch

✅ Encode3dRangeRelative3dRange

• ✅ Our implementation has canonic decoding, but Willow doesn't use that any longer. fixed on test_vectors branch

TODO: check state of Sideloading entry encoding