Bug fixes in elemshape data

Using the range of matrices in methods related to Set1 and Set4.
This is because, we get node coord from mesh, we get the 3 components
even for a 2D problem. It causes some issue in while setting
global element shape data.

Author: vickysharma0812

src/modules/ElemshapeData/src/ElemshapeData_Method.F90

@@ -20,15 +20,6 @@ MODULE ElemshapeData_Method
 USE ElemshapeData_GetMethods
 USE ElemshapeData_GradientMethods
 
-! USE ElemshapeData_H1Methods
-! USE ElemshapeData_HCurlMethods
-! USE ElemshapeData_HDivMethods
-! USE ElemshapeData_DGMethods
-
-USE ElemshapeData_Lagrange
-USE ElemshapeData_Hierarchical
-USE ElemshapeData_Orthogonal
-
 USE ElemshapeData_HRGNParamMethods
 USE ElemshapeData_HRQIParamMethods
 USE ElemshapeData_HminHmaxMethods
@@ -41,4 +32,14 @@ MODULE ElemshapeData_Method
 USE ElemshapeData_StabilizationParamMethods
 USE ElemshapeData_UnitNormalMethods
 
+! USE ElemshapeData_H1Methods
+! USE ElemshapeData_HCurlMethods
+! USE ElemshapeData_HDivMethods
+! USE ElemshapeData_DGMethods
+
+USE ElemshapeData_Lagrange
+USE ElemshapeData_Hierarchical
+USE ElemshapeData_Orthogonal
+
+
 END MODULE ElemshapeData_Method

src/modules/ElemshapeData/src/ElemshapeData_SetMethods.F90

@@ -242,6 +242,9 @@ MODULE PURE SUBROUTINE stsd_SetJacobian(obj, val, dNdXi, T)
     CLASS(STElemshapeData_), INTENT(INOUT) :: obj
     REAL(DFP), INTENT(IN) :: val(:, :, :)
     !! Space time nodal values of coordinates
+    !! dim1 = spatial coordinates
+    !! dim2 = space nodes
+    !! dim3 = time nodes
     REAL(DFP), INTENT(IN) :: dNdXi(:, :, :)
     !! Local derivative of shape function for geometry
     REAL(DFP), INTENT(IN) :: T(:)

src/submodules/ElemshapeData/src/[email protected]

@@ -49,14 +49,19 @@
 !----------------------------------------------------------------------------
 
 MODULE PROCEDURE elemsd_SetBarycentricCoord
-obj%coord(1:obj%nsd, 1:obj%nips) = MATMUL(val, N)
+INTEGER(I4B) :: nns
+nns = SIZE(N, 1)
+obj%coord(1:obj%nsd, 1:obj%nips) = MATMUL(val(1:obj%nsd, 1:nns), &
+                                          N(1:nns, 1:obj%nips))
 END PROCEDURE elemsd_SetBarycentricCoord
 
 !----------------------------------------------------------------------------
 !                                                        SetBarycentricCoord
 !----------------------------------------------------------------------------
 
 MODULE PROCEDURE stsd_SetBarycentricCoord
+! TODO: Improve this function by removing the temporary variable 
+! It is better to store a temporary variable in obj itself
 CALL SetBarycentricCoord(obj=obj, val=MATMUL(val, T), N=N)
 END PROCEDURE stsd_SetBarycentricCoord
 
@@ -136,15 +141,18 @@
 !----------------------------------------------------------------------------
 
 MODULE PROCEDURE elemsd_SetJacobian
-obj%jacobian(1:obj%nsd, 1:obj%xidim, 1:obj%nips) = MATMUL(val, dNdXi)
+obj%jacobian(1:obj%nsd, 1:obj%xidim, 1:obj%nips) = &
+  MATMUL(val(1:obj%nsd, 1:obj%nns), dNdXi(1:obj%nns, 1:obj%xidim, 1:obj%nips))
 END PROCEDURE elemsd_SetJacobian
 
 !----------------------------------------------------------------------------
 !                                                                 SetJacobian
 !----------------------------------------------------------------------------
 
 MODULE PROCEDURE stsd_SetJacobian
-obj%jacobian = MATMUL(MATMUL(val, T), dNdXi)
+obj%jacobian(1:obj%nsd, 1:obj%xidim, 1:obj%nips) = &
+  MATMUL(MATMUL(val(1:obj%nsd, 1:obj%nns, :), T), &
+         dNdXi(1:obj%nns, 1:obj%xidim, 1:obj%nips))
 END PROCEDURE stsd_SetJacobian
 
 !----------------------------------------------------------------------------