Skip to content

Commit ce695dc

Browse files
committed
chore(): update istanbul-lib-instrument to support ESM when reading coverage
1 parent 8617fae commit ce695dc

File tree

9 files changed

+34
-71
lines changed

9 files changed

+34
-71
lines changed
Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
// istanbul ignore file
22
import { wrap } from "comlink";
33
import type { MiniLineChartOptions } from "./draw.js";
4-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
5-
// @ts-ignore
6-
import { getChartWorker } from "./worker.mjs";
74

85
export interface RemoteWorker {
96
init(id: string, canvas: OffscreenCanvas): Promise<void>;
@@ -13,12 +10,21 @@ export interface RemoteWorker {
1310

1411
let remoteWorkerPromise: Promise<RemoteWorker> | undefined;
1512

13+
let worker: Worker | undefined;
14+
1615
export function getRemoteWorker() {
1716
if (!remoteWorkerPromise) {
1817
remoteWorkerPromise = (async () => {
19-
const Remote = wrap(getChartWorker()) as any;
18+
const Remote = wrap<{ new (): RemoteWorker }>(getWorker());
2019
return await new Remote();
2120
})();
2221
}
2322
return remoteWorkerPromise;
2423
}
24+
25+
function getWorker() {
26+
if (!worker) {
27+
worker = new Worker(new URL("./chart.worker.ts", import.meta.url));
28+
}
29+
return worker;
30+
}

bricks/mini-chart/src/mini-line-chart/index.spec.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ jest.mock("./getRemoteWorker.js", () => ({
1414
});
1515
},
1616
}));
17-
jest.mock("./worker.mjs", () => ({}));
1817
jest.mock("./draw.js");
1918

2019
jest.mock(

bricks/mini-chart/src/mini-line-chart/worker.mjs

Lines changed: 0 additions & 20 deletions
This file was deleted.

bricks/vs/src/code-editor/index.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import * as monaco from "monaco-editor/esm/vs/editor/editor.api.js";
77

88
jest.mock("@next-core/theme", () => ({}));
99
jest.mock("@next-core/react-runtime");
10-
jest.mock("./workers/yamlLinter", () => ({}));
10+
jest.mock("./workers/yamlLinter.js", () => ({}));
1111

1212
global.ResizeObserver = ResizeObserver as any;
1313

bricks/vs/src/code-editor/index.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@ import classNames from "classnames";
5252
import "./index.css";
5353
import { EmbeddedModelContext } from "./utils/embeddedModelState.js";
5454
import { PlaceholderContentWidget } from "./widget/Placeholder.js";
55-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
56-
// @ts-ignore
57-
import { getYamlLinterWorker } from "./workers/yamlLinter.mjs";
55+
import { getYamlLinterWorker } from "./workers/yamlLinter.js";
5856
import type { LintResponse } from "./workers/lintYaml.js";
5957
import { register as registerCel } from "./languages/cel.js";
6058
import { register as registerCelYaml } from "./languages/cel-yaml.js";

bricks/vs/src/code-editor/workers/yamlLinter.mjs

Lines changed: 0 additions & 20 deletions
This file was deleted.
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
// istanbul ignore file
2+
3+
let worker: Worker | undefined;
4+
5+
export function getYamlLinterWorker() {
6+
if (!worker) {
7+
worker = new Worker(new URL("./yamlLinter.worker.ts", import.meta.url));
8+
}
9+
return worker;
10+
}

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@
101101
"@babel/runtime": "^7.24.4",
102102
"@types/hast": "^3.0.4",
103103
"@types/react": "^18.2.79",
104+
"istanbul-lib-instrument": "^6.0.3",
104105
"lodash": "^4.17.21",
105106
"moment": "^2.30.1"
106107
}

yarn.lock

Lines changed: 11 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,7 @@
537537
resolved "https://registry.yarnpkg.com/@babel/compat-data/-/compat-data-7.26.8.tgz#821c1d35641c355284d4a870b8a4a7b0c141e367"
538538
integrity sha512-oH5UPLMWR3L2wEFLnFJ1TZXqHufiTKAiLfqw5zkhS4dKXLJ10yVztfil/twG8EDTA4F/tvVNw9nOl4ZMslB8rQ==
539539

540-
"@babel/core@^7.11.6", "@babel/core@^7.12.3", "@babel/core@^7.16.0", "@babel/core@^7.21.3", "@babel/core@^7.26.10":
540+
"@babel/core@^7.11.6", "@babel/core@^7.16.0", "@babel/core@^7.21.3", "@babel/core@^7.23.9", "@babel/core@^7.26.10":
541541
version "7.26.10"
542542
resolved "https://registry.yarnpkg.com/@babel/core/-/core-7.26.10.tgz#5c876f83c8c4dcb233ee4b670c0606f2ac3000f9"
543543
integrity sha512-vMqyb7XCDMPvJFFOaT9kxtiRh42GwlZEg1/uIgtZshS5a/8OaduUfCi7kynKgc3Tw/6Uo2D+db9qBttghhmxwQ==
@@ -715,7 +715,7 @@
715715
"@babel/template" "^7.26.9"
716716
"@babel/types" "^7.26.10"
717717

718-
"@babel/parser@^7.1.0", "@babel/parser@^7.14.7", "@babel/parser@^7.20.7", "@babel/parser@^7.22.7", "@babel/parser@^7.24.4", "@babel/parser@^7.26.10", "@babel/parser@^7.26.9":
718+
"@babel/parser@^7.1.0", "@babel/parser@^7.20.7", "@babel/parser@^7.22.7", "@babel/parser@^7.23.9", "@babel/parser@^7.24.4", "@babel/parser@^7.26.10", "@babel/parser@^7.26.9":
719719
version "7.25.3"
720720
resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.25.3.tgz#91fb126768d944966263f0657ab222a642b82065"
721721
integrity sha512-iLTJKDbJ4hMvFPgQwwsVoxtHyWpKKPBrxkANrSYewDPaPpT5py5yeVkgPIJ7XYXhndxJpaA3PyALSXQ7u8e/Dw==
@@ -2214,7 +2214,7 @@
22142214
js-yaml "^3.13.1"
22152215
resolve-from "^5.0.0"
22162216

2217-
"@istanbuljs/schema@^0.1.2":
2217+
"@istanbuljs/schema@^0.1.2", "@istanbuljs/schema@^0.1.3":
22182218
version "0.1.3"
22192219
resolved "https://registry.yarnpkg.com/@istanbuljs/schema/-/schema-0.1.3.tgz#e45e384e4b8ec16bce2fd903af78450f6bf7ec98"
22202220
integrity sha512-ZXRY4jNvVgSVQ8DL3LTcakaAtXwTVUxE81hslsyD2AtoXW/wVob10HkOJ1X/pAlcI7D+2YoZKg5do8G/w6RYgA==
@@ -10454,25 +10454,14 @@ istanbul-lib-coverage@^3.0.0, istanbul-lib-coverage@^3.2.0:
1045410454
resolved "https://registry.yarnpkg.com/istanbul-lib-coverage/-/istanbul-lib-coverage-3.2.0.tgz#189e7909d0a39fa5a3dfad5b03f71947770191d3"
1045510455
integrity sha512-eOeJ5BHCmHYvQK7xt9GkdHuzuCGS1Y6g9Gvnx3Ym33fz/HpLRYxiS0wHNr+m/MBC8B647Xt608vCDEvhl9c6Mw==
1045610456

10457-
istanbul-lib-instrument@^5.0.4:
10458-
version "5.2.1"
10459-
resolved "https://registry.yarnpkg.com/istanbul-lib-instrument/-/istanbul-lib-instrument-5.2.1.tgz#d10c8885c2125574e1c231cacadf955675e1ce3d"
10460-
integrity sha512-pzqtp31nLv/XFOzXGuvhCb8qhjmTVo5vjVk19XE4CRlSWz0KoeJ3bw9XsA7nOp9YBf4qHjwBxkDzKcME/J29Yg==
10461-
dependencies:
10462-
"@babel/core" "^7.12.3"
10463-
"@babel/parser" "^7.14.7"
10464-
"@istanbuljs/schema" "^0.1.2"
10465-
istanbul-lib-coverage "^3.2.0"
10466-
semver "^6.3.0"
10467-
10468-
istanbul-lib-instrument@^6.0.0:
10469-
version "6.0.0"
10470-
resolved "https://registry.yarnpkg.com/istanbul-lib-instrument/-/istanbul-lib-instrument-6.0.0.tgz#7a8af094cbfff1d5bb280f62ce043695ae8dd5b8"
10471-
integrity sha512-x58orMzEVfzPUKqlbLd1hXCnySCxKdDKa6Rjg97CwuLLRI4g3FHTdnExu1OqffVFay6zeMW+T6/DowFLndWnIw==
10457+
istanbul-lib-instrument@^5.0.4, istanbul-lib-instrument@^6.0.0, istanbul-lib-instrument@^6.0.3:
10458+
version "6.0.3"
10459+
resolved "https://registry.yarnpkg.com/istanbul-lib-instrument/-/istanbul-lib-instrument-6.0.3.tgz#fa15401df6c15874bcb2105f773325d78c666765"
10460+
integrity sha512-Vtgk7L/R2JHyyGW07spoFlB8/lpjiOLTjMdms6AFMraYt3BaJauod/NGrfnVG/y4Ix1JEuMRPDPEj2ua+zz1/Q==
1047210461
dependencies:
10473-
"@babel/core" "^7.12.3"
10474-
"@babel/parser" "^7.14.7"
10475-
"@istanbuljs/schema" "^0.1.2"
10462+
"@babel/core" "^7.23.9"
10463+
"@babel/parser" "^7.23.9"
10464+
"@istanbuljs/schema" "^0.1.3"
1047610465
istanbul-lib-coverage "^3.2.0"
1047710466
semver "^7.5.4"
1047810467

@@ -16285,7 +16274,7 @@ scroll-into-view-if-needed@^3.1.0:
1628516274
resolved "https://registry.yarnpkg.com/semver/-/semver-5.7.1.tgz#a954f931aeba508d307bbf069eff0c01c96116f7"
1628616275
integrity sha512-sauaDf/PZdVgrLTNYHRtpXa1iRiKcaebiKQ1BJdpQlWH2lCvexQdX55snPFyK7QzpudqbCI0qXFfOasHdyNDGQ==
1628716276

16288-
semver@^6.0.0, semver@^6.3.0, semver@^6.3.1:
16277+
semver@^6.0.0, semver@^6.3.1:
1628916278
version "6.3.1"
1629016279
resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.1.tgz#556d2ef8689146e46dcea4bfdd095f3434dffcb4"
1629116280
integrity sha512-BR7VvDCVHO+q2xBEWskxS6DJE1qRnb7DxzUrogb71CWoSficBxYsiAGd+Kl0mmq/MprG9yArRkyrQxTO6XjMzA==

0 commit comments

Comments
 (0)