Skip to content

Commit a3fc92f

Browse files
author
astrid
committed
fix(form): labelBrick 位置不对
refs DASHBOARD-522
1 parent 61790c8 commit a3fc92f

File tree

3 files changed

+28
-4
lines changed

3 files changed

+28
-4
lines changed

bricks/form/src/form-item/index.spec.tsx

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import React from "react";
12
import { FormItem } from "./";
23
import { describe, test, expect } from "@jest/globals";
34
import { act } from "react-dom/test-utils";
@@ -6,6 +7,11 @@ import { Form } from "../form/index.js";
67

78
jest.mock("./FormItem.shadow.less", () => "");
89
jest.mock("@next-core/theme", () => ({}));
10+
jest.mock("@next-core/react-runtime", () => ({
11+
ReactUseMultipleBricks: () => {
12+
return <div>mock element</div>;
13+
},
14+
}));
915

1016
describe("eo-form-item", () => {
1117
test("basic usage", async () => {
@@ -30,6 +36,22 @@ describe("eo-form-item", () => {
3036
element.trigger = "change";
3137
element.label = "测试";
3238
element.required = true;
39+
element.labelBrick = {
40+
useBrick: {
41+
brick: "span",
42+
properties: {
43+
textContent: "labelBrick",
44+
},
45+
},
46+
};
47+
element.helpBrick = {
48+
useBrick: {
49+
brick: "span",
50+
properties: {
51+
textContent: "helpBrick",
52+
},
53+
},
54+
};
3355

3456
expect(element.shadowRoot).toBeFalsy();
3557
act(() => {
@@ -71,7 +93,6 @@ describe("eo-form-item", () => {
7193
act(() => {
7294
document.body.removeChild(element);
7395
});
74-
7596
expect(mockFormStore.removeField).toBeCalledTimes(1);
7697
expect(mockFormStore.unsubscribe).toBeCalledTimes(5);
7798
expect(element.shadowRoot?.childNodes.length).toBe(0);

bricks/form/src/form-item/index.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -317,10 +317,12 @@ export function FormItemComponent(props: FormItemProps) {
317317
<label>
318318
{required && <span className="required">*</span>}
319319
{label}
320+
{labelBrick?.useBrick ? (
321+
<ReactUseMultipleBricks
322+
{...labelBrick}
323+
></ReactUseMultipleBricks>
324+
) : null}
320325
</label>
321-
{labelBrick?.useBrick ? (
322-
<ReactUseMultipleBricks {...labelBrick}></ReactUseMultipleBricks>
323-
) : null}
324326
</div>
325327
</div>
326328
)}

bricks/form/src/upload/upload-image/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ class UploadImage extends FormItemElementBase implements UploadImageProps {
144144
helpBrick={this.helpBrick}
145145
onChange={this.handleChange}
146146
trigger="handleChange"
147+
labelBrick={this.labelBrick}
147148
/>
148149
);
149150
}

0 commit comments

Comments
 (0)