fix(): dot not re-render controlled nodes before mounted

Author: weareoutman

packages/runtime/src/internal/Renderer.ts

@@ -592,12 +592,16 @@ async function legacyRenderBrick(
       type: "initial",
       runtimeContext,
     });
-
     const { onMount, onUnmount } = brickConf.lifeCycle ?? {};
 
     if (tracking) {
       let renderId = 0;
       const listener = async () => {
+        // TODO(steve): start listeners when mounting, and handle changes between rendering and mounting.
+        if (!returnNode.mounted || returnNode.disposed) {
+          return;
+        }
+
         const currentRenderId = ++renderId;
         const [scopedRuntimeContext, tplStateStoreScope, formStateStoreScope] =
           createScopedRuntimeContext(runtimeContext);
@@ -612,7 +616,8 @@ async function legacyRenderBrick(
         // Ignore stale renders
         if (
           renderId === currentRenderId &&
-          !(returnNode.tag !== RenderTag.ROOT && returnNode.disposed)
+          returnNode.mounted &&
+          !returnNode.disposed
         ) {
           if (onUnmount) {
             listenerFactory(

packages/runtime/src/internal/interfaces.ts

@@ -68,7 +68,6 @@ export interface RenderAbstract extends BaseRenderNode {
   return: RenderReturnNode;
   iid?: string;
   disposes?: (() => void)[];
-  disposed?: boolean;
 }
 
 export interface BaseRenderNode {
@@ -77,6 +76,8 @@ export interface BaseRenderNode {
   sibling?: RenderChildNode;
   return?: RenderReturnNode | null;
   childElements?: HTMLElement[];
+  disposed?: boolean;
+  mounted?: boolean;
 }
 
 export type RenderNode = RenderRoot | RenderBrick | RenderAbstract;

packages/runtime/src/internal/mount.ts

@@ -17,10 +17,12 @@ export function mountTree(
   root: RenderRoot,
   initializedElement?: RuntimeBrickElement
 ): void {
+  root.mounted = true;
   window.DISABLE_REACT_FLUSH_SYNC = false;
   let current = root.child;
   const portalElements: RuntimeBrickElement[] = [];
   while (current) {
+    current.mounted = true;
     if (current.tag === RenderTag.BRICK) {
       const tagName = current.type;