fix(): dispatch onMessageClose only after retry limit exceeded

Author: weareoutman

packages/easyops-runtime/src/websocket/MessageDispatcher.spec.ts

@@ -136,9 +136,8 @@ describe("MessageDispatcher", () => {
     );
     expect(consoleError).toHaveBeenCalledTimes(2);
 
-    expect(onClose).not.toBeCalled();
     server.close();
-    expect(onClose).toBeCalledTimes(1);
+    expect(onClose).not.toBeCalled();
 
     client.reset();
   });

packages/easyops-runtime/src/websocket/MessageService.spec.ts

@@ -53,7 +53,7 @@ describe("MessageService", () => {
       wasClean: false,
     });
     expect(consoleError).toBeCalledWith("WebSocket error:", expect.anything());
-    expect(onClose).toBeCalledTimes(1);
+    expect(onClose).not.toBeCalled();
 
     expect(consoleLog).toBeCalledWith(
       "WebSocket will reconnect after %d seconds",

packages/easyops-runtime/src/websocket/MessageService.ts

@@ -47,9 +47,6 @@ export class MessageService {
       }
       // eslint-disable-next-line no-console
       console.log("WebSocket close:", e);
-      for (const listener of this.#closeListeners) {
-        listener();
-      }
       // Error code 1000 means that the connection was closed normally.
       if (e.code !== 1000) {
         this.#reconnect();
@@ -75,6 +72,10 @@ export class MessageService {
     if (this.#retryCount >= RETRY_LIMIT) {
       // eslint-disable-next-line no-console
       console.error("WebSocket connect retry limit exceeded");
+      // Keep behavior as v2: emit close event only after retry limit exceeded
+      for (const listener of this.#closeListeners) {
+        listener();
+      }
       return;
     }
     // Double the timeout for each retry