-
Notifications
You must be signed in to change notification settings - Fork 11
fix(Router): ignore blacklist paths of external link #4810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Router): ignore blacklist paths of external link #4810
Conversation
Closes PERMISSION-832
概览修改了路径黑名单机制,仅当路径真实且以"/"开头时才添加到黑名单,同时在测试中验证外部URL被排除。 变更
代码审查工作量估计🎯 2 (Simple) | ⏱️ ~10 分钟 Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #4810 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 212 212
Lines 9317 9317
Branches 1792 1792
=======================================
Hits 8870 8870
Misses 328 328
Partials 119 119
🚀 New features to boost your workflow:
|
next-core
|
||||||||||||||||||||||||||||
| Project |
next-core
|
| Branch Review |
williamcai/v3/runtime/Router/ignore_blacklist_paths_of_external_link
|
| Run status |
|
| Run duration | 00m 27s |
| Commit |
|
| Committer | William Cai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
17
|
| View all changes introduced in this branch ↗︎ | |
Closes PERMISSION-832
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat作为提交类型。BREAKING CHANGE: 你的变更说明。新特性:
feat作为提交类型。问题修复:
fix作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore,docs,test等作为提交类型。Summary by CodeRabbit
Bug Fixes