Skip to content

Conversation

@weareoutman
Copy link
Member

依赖检查

组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。

请勾选以下两组选项其中之一:

  • 本次 MR 没有使用上游组件(例如框架、后台组件等)的较新版本提供的特性。

或者:

  • 本次 MR 使用了上游组件(例如框架、后台组件等)的较新版本提供的特性。
  • 在对应的文件中更新了该上游组件的依赖版本(或确认了当前声明的依赖版本已包含本次 MR 使用的新特性)。

提交信息检查

Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。

破坏性变更是针对于下游使用者而言,可以通过本次改动对下游使用者的影响来识别变更类型:

  • 下游使用者不做任何改动,仍可以正常工作时,那么它属于普通变更。
  • 反之,下游使用者不做改动就无法正常工作时,那么它属于破坏性变更。

例如,构件修改了一个属性名,小产品 Storyboard 中需要使用新属性名才能工作,那么它就是破坏性变更。
又例如,构件还没有任何下游使用者,那么它的任何变更都是普通变更。

破坏性变更:

  • ⚠️ 本次 MR 包含破坏性变更的提交,请继续确认以下所有选项:
  • 没有更好的兼容方案,必须做破坏性变更。
  • 使用了 feat 作为提交类型。
  • 标注了 BREAKING CHANGE: 你的变更说明
  • 同时更新了本仓库中所有下游使用者的调用。
  • 同时更新了本仓库中所有下游使用者对该子包的依赖为即将发布的 major 版本。
  • 同时为其它仓库的 Migrating 做好了准备,例如文档或批量改动的方法。
  • 手动验证过破坏性变更在 Migrate 后可以正常工作。
  • 破坏性变更所在的提交没有意外携带其它子包的改动。

新特性:

  • 本次 MR 包含新特性的提交,且该提交不带有破坏性变更,并使用了 feat 作为提交类型。
  • 给新特性添加了单元测试。
  • 手动验证过新特性可以正常工作。

问题修复:

  • 本次 MR 包含问题修复的提交,且该提交不带有新特性或破坏性变更,并使用了 fix 作为提交类型。
  • 给问题修复添加了单元测试。
  • 手动验证过问题修复得到解决。

杂项工作:

即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:

  • 本次 MR 包含杂项工作的提交,且该提交不带有问题修复、新特性或破坏性变更,并使用了 chore, docs, test 等作为提交类型。

Comment on lines 9 to 32
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v4

- name: Cleanup
run: |
gh extension install actions/gh-actions-cache

echo "Fetching list of cache key"
cacheKeysForPR=$(gh actions-cache list -R $REPO -B $BRANCH -L 100 | cut -f 1 )

## Setting this to not fail the workflow while deleting cache keys.
set +e
echo "Deleting caches..."
for cacheKey in $cacheKeysForPR
do
gh actions-cache delete $cacheKey -R $REPO -B $BRANCH --confirm
done
echo "Done"
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
REPO: ${{ github.repository }}
BRANCH: refs/pull/${{ github.event.pull_request.number }}/merge

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI about 2 months ago

To fix this problem, we should add an explicit permissions: block to the workflow's sole job (cleanup). This block should set the least privileges needed for the workflow steps to function. In this case, since the job installs and invokes the gh-actions-cache extension (which deletes caches), the workflow needs write access to the GitHub Actions caches via the actions scope—so actions: write is required. There is no evidence it needs any other permissions (like contents, pull-requests, etc.) for its purpose.

This change should be made inside the job definition (under jobs.cleanup:), inserted before or after runs-on: (as per GitHub Actions YAML conventions). No new imports, methods or definitions are needed.

Suggested changeset 1
.github/workflows/cleanup-caches.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/cleanup-caches.yml b/.github/workflows/cleanup-caches.yml
--- a/.github/workflows/cleanup-caches.yml
+++ b/.github/workflows/cleanup-caches.yml
@@ -7,6 +7,8 @@
 jobs:
   cleanup:
     runs-on: ubuntu-latest
+    permissions:
+      actions: write
     steps:
       - name: Check out code
         uses: actions/checkout@v4
EOF
@@ -7,6 +7,8 @@
jobs:
cleanup:
runs-on: ubuntu-latest
permissions:
actions: write
steps:
- name: Check out code
uses: actions/checkout@v4
Copilot is powered by AI and may make mistakes. Always verify output.
@weareoutman weareoutman reopened this Oct 21, 2025
@weareoutman weareoutman changed the base branch from master to v3 October 21, 2025 10:34
@weareoutman weareoutman reopened this Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.20%. Comparing base (14446c6) to head (0510f06).
⚠️ Report is 2 commits behind head on v3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##               v3    #4812   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files         212      212           
  Lines        9317     9319    +2     
  Branches     1792     1793    +1     
=======================================
+ Hits         8870     8872    +2     
  Misses        328      328           
  Partials      119      119           
Files with missing lines Coverage Δ
.../runtime/src/internal/compute/setRealProperties.ts 80.00% <100.00%> (+2.22%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Oct 21, 2025

next-core    Run #11765

Run Properties:  status check passed Passed #11765  •  git commit 14d6e44491 ℹ️: Merge 0510f06fa84b06bdfc63fb5a0cdce22cc6bb3514 into 14446c604ce4566046afc335665e...
Project next-core
Branch Review steve/v3-data-attrs
Run status status check passed Passed #11765
Run duration 00m 24s
Commit git commit 14d6e44491 ℹ️: Merge 0510f06fa84b06bdfc63fb5a0cdce22cc6bb3514 into 14446c604ce4566046afc335665e...
Committer Shenwei Wang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 17
View all changes introduced in this branch ↗︎

@weareoutman weareoutman requested a review from Copilot October 21, 2025 10:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for setting HTML data attributes (e.g., data-test, data-info) directly on elements by checking for the data- prefix and using setAttribute instead of property assignment.

Key Changes

  • Modified setRealProperties to detect properties starting with data- and set them as HTML attributes using setAttribute
  • Added test coverage for the new data attribute functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/runtime/src/internal/compute/setRealProperties.ts Added conditional logic to handle data- prefixed properties as HTML attributes
packages/runtime/src/internal/compute/setRealProperties.spec.ts Added test case to verify data attributes are correctly set on elements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@weareoutman weareoutman merged commit a94e161 into v3 Oct 21, 2025
11 checks passed
@weareoutman weareoutman deleted the steve/v3-data-attrs branch October 21, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants