-
Notifications
You must be signed in to change notification settings - Fork 11
fix(): use jsx.ts instead of jsx.d.ts for source file #4819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
next-core
|
||||||||||||||||||||||||||||
| Project |
next-core
|
| Branch Review |
steve/v3-fix-jsx
|
| Run status |
|
| Run duration | 00m 26s |
| Commit |
|
| Committer | Shenwei Wang |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
17
|
| View all changes introduced in this branch ↗︎ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames the JSX declaration file from jsx.d.ts to jsx.ts and updates references throughout the codebase. The change allows TypeScript to emit declarations directly without requiring a post-processing step.
- Changed template file extension from
.d.ts.hbsto.ts.hbswith an ESLint disable comment - Removed the
copy-jsx-d-tscommand from the build pipeline - Updated file path references and error messages in plopfile.js
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/yo/src/templates/bricks/src/jsx.ts.hbs | Renamed from .d.ts.hbs to .ts.hbs and added ESLint disable comment for namespace usage |
| packages/yo/src/templates/bricks/package.json.hbs | Removed copy-jsx-d-ts post-processing command from build:types script |
| packages/yo/src/plopfile.js | Updated file path references from jsx.d.ts to jsx.ts and corrected error messages |
Comments suppressed due to low confidence (3)
packages/yo/src/templates/bricks/package.json.hbs:14
- The types field still references 'jsx.d.ts' but the source file has been renamed to 'jsx.ts'. Since TypeScript will emit 'jsx.d.ts' to dist-types, this should remain as is. However, given that the source is now a .ts file, verify that the TypeScript compiler generates the expected jsx.d.ts output file in the dist-types directory.
"types": "dist-types/jsx.d.ts",
packages/yo/src/templates/bricks/package.json.hbs:19
- The exports field still references 'jsx.d.ts' but the source file has been renamed to 'jsx.ts'. Since TypeScript will emit 'jsx.d.ts' to dist-types, this should remain as is. However, given that the source is now a .ts file, verify that the TypeScript compiler generates the expected jsx.d.ts output file in the dist-types directory.
".": "./dist-types/jsx.d.ts",
packages/yo/src/plopfile.js:317
- The function name 'updateJsxDts' is now misleading since it updates 'jsx.ts' files rather than 'jsx.d.ts' files. Consider renaming to 'updateJsxTs' or 'updateJsx' for clarity.
async function updateJsxDts(answers) {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Caution Review failedThe pull request is closed. 概览将生成的类型声明文件从 jsx.d.ts 重命名为 jsx.ts,更新相应的模板文件路径和错误消息文本,并在构建脚本中移除 copy-jsx-d-ts 命令。 变更
代码审查工作量评估🎯 2 (简单) | ⏱️ ~12 分钟
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat作为提交类型。BREAKING CHANGE: 你的变更说明。新特性:
feat作为提交类型。问题修复:
fix作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore,docs,test等作为提交类型。Summary by CodeRabbit
发布说明