fix, tests

Author: strengejacke

R/format_p_adjust.R

@@ -101,7 +101,12 @@ format_p_adjust <- function(method) {
       if (!is.null(by_vars) && by_vars %in% colnames(params)) {
         correction <- insight::n_unique(params[[by_vars]])
       } else {
-        correction <- prod(vapply(model@model.info$xlev, length, numeric(1)))
+        correction <- .safe(prod(vapply(model@model.info$xlev, length, numeric(1))))
+        correction <- .safe(insight::n_unique(unlist(strsplit(
+          model@levels$contrast,
+          " - ",
+          fixed = TRUE
+        ))))
       }
 
       correction

tests/testthat/test-p_adjust.R

@@ -88,6 +88,13 @@ test_that("model_parameters, emmeans, p-adjust", {
   myc <- pairs(emmeans::emmeans(warp.lm, ~ wool + tension))
   mp <- model_parameters(myc, p_adjust = "tukey")
   expect_equal(mp$p, as.data.frame(myc)$p.value, tolerance = 1e-4)
+
+  skip_if(getRversion() < "4.5.0")
+  data(penguins)
+  m <- lm(bill_len ~ sex * species + island, data = penguins)
+  emm <- pairs(emmeans::emmeans(m, ~ sex + species))
+  mp <- model_parameters(emm, p_adjust = "tukey")
+  expect_equal(mp$p, as.data.frame(emm)$p.value, tolerance = 1e-4)
 })