don't force spilling to stack in range validators

Author: tomjnixon

include/adm/detail/named_type_validators.hpp

@@ -29,7 +29,7 @@ namespace adm {
     /// the type, so reduces duplication
     template <typename T>
     struct ValidateRangeHelper {
-      static void validateRange(const T& value, int minValue, int maxValue) {
+      static void validateRange(T value, int minValue, int maxValue) {
         if (value > static_cast<T>(maxValue) ||
             value < static_cast<T>(minValue)) {
           std::stringstream msg;
@@ -39,15 +39,15 @@ namespace adm {
         }
       }
 
-      static void validateMin(const T& value, int minValue) {
+      static void validateMin(T value, int minValue) {
         if (value < static_cast<T>(minValue)) {
           std::stringstream msg;
           msg << "'" << value << "'' is not bigger than '" << minValue << "'";
           throw OutOfRangeError(msg.str());
         }
       }
 
-      static void validateMax(const T& value, int maxValue) {
+      static void validateMax(T value, int maxValue) {
         if (value > static_cast<T>(maxValue)) {
           std::stringstream msg;
           msg << "'" << value << "'' is not smaller than '" << maxValue << "'";
@@ -74,23 +74,23 @@ namespace adm {
     template <int minValue, int maxValue>
     struct RangeValidator {
       template <typename T>
-      static void validate(const T& value) {
+      static void validate(T value) {
         ValidateRangeHelper<T>::validateRange(value, minValue, maxValue);
       }
     };
 
     template <int minValue>
     struct MinValidator {
       template <typename T>
-      static void validate(const T& value) {
+      static void validate(T value) {
         ValidateRangeHelper<T>::validateMin(value, minValue);
       }
     };
 
     template <int maxValue>
     struct MaxValidator {
       template <typename T>
-      static void validate(const T& value) {
+      static void validate(T value) {
         ValidateRangeHelper<T>::validateMax(value, maxValue);
       }
     };