Skip to content

Commit 7ea0fab

Browse files
committed
Merge pull request #8 from ebu/feat/include-skipAnimation-in-all-actions
Include optional property skipAnimation in all actions
2 parents 98da562 + 1c5dafe commit 7ea0fab

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,5 @@ The log below details the changes during development of this version:
1919
Before, the `data`-payload was only sent using the `updateData()` method. Now it must be sent on `load()` as well.
2020
* 2025-05-16: Change return values of Graphic methods to optionally be `undefined`.
2121
(An `undefined` value should be treated as `{ code: 200 }`)
22+
* 2025-xx-xx: Add optional `skipAnimation` argument to `updateAction` and `customAction`.
23+
Before, it was only included in `playAction` and `stopAction`.

v1/typescript-definitions/src/apis/graphicsAPI.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ export interface Graphic {
5050
params: {
5151
/** The data send here is defined in the manifest "schema". Note: This data MUST HAVE the same type as the `data` argument in the load method. */
5252
data: unknown;
53+
/** If true, skips animation (defaults to false) */
54+
skipAnimation?: boolean;
5355
} & VendorExtend
5456
) => Promise<ReturnPayload | undefined>;
5557

@@ -61,13 +63,16 @@ export interface Graphic {
6163
/** Jump to a specific step/segment (defaults to undefined) */
6264
goto: number;
6365
/** If true, skips animation (defaults to false) */
64-
skipAnimation: boolean;
66+
skipAnimation?: boolean;
6567
} & VendorExtend
6668
) => Promise<PlayActionReturnPayload>;
6769

6870
/** This is called when user calls the "stop" action. */
6971
stopAction: (
70-
params: { skipAnimation: boolean } & VendorExtend
72+
params: {
73+
/** If true, skips animation (defaults to false) */
74+
skipAnimation?: boolean
75+
} & VendorExtend
7176
) => Promise<ReturnPayload | undefined>;
7277

7378
/**

v1/typescript-definitions/src/definitions/types.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ export type ActionInvokeParams = {
4040
id: string;
4141
/** Params to send into the method */
4242
payload: unknown;
43+
44+
/** If true, skips animation (defaults to false) */
45+
skipAnimation?: boolean;
4346
} & VendorExtend;
4447

4548
export type PlayActionReturnPayload = (ReturnPayload | {}) & {

0 commit comments

Comments
 (0)