Skip to content

NEPT-1534: Double-check component implementation for inconsistencies: #22

Open
@ademarco

Description

@ademarco

In particular:

  • Component is using but we currently use instead
  • is not mentioned in documentation but we are using it, clarify this
  • For contacts, we use type auteur, we don't use 'planningUnit' neither 'translationUnit': check which one to keep
  • In EC\Poetry\Messages\Components\ReturnAddress 'WebService' should start with lowercase in (2x) 'expression' => 'this.getType() == "webService"': Check this.
  • "ReturnAddress()->setRemark" call: Why is it mandatory to call it when we introduce a blank? the blank value cannot be the default value?
  • Add tests for all tasks above

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions