Skip to content

Client class assumes we receive a XML as a response. #81

Open
@imanoleguskiza

Description

@imanoleguskiza

On the send method of the EC\Poetry\Client we assume the response from the server is going to be an XML. This is a problem because if we don't (we receive an error string for example) we will trigger a Parsing Exception, which is not correct.

A solution would be to check if the response is a properly formatter XML and if it isn't simply return the string or throw an exception.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions