Merge pull request #3491 from ecency/bugfix/pre-release-hardening

Pre-release hardening: parseAsset, sheet model, navigation contract, delete default

Author: feruzm

src/components/accountsBottomSheet/container/accountsBottomSheetContainer.tsx

@@ -5,7 +5,8 @@ import { useIntl } from 'react-intl';
 import { Alert } from 'react-native';
 import { SheetManager } from 'react-native-actions-sheet';
 import { getMutedUsersQueryOptions, getNotificationsUnreadCountQueryOptions } from '@ecency/sdk';
-import RootNavigation from '../../../navigation/rootNavigation';
+import RootNavigation, { NavigateOptions } from '../../../navigation/rootNavigation';
+import { NavigateArgs, RouteName } from '../../../navigation/types';
 
 import { setPrevLoggedInUsers, updateCurrentAccount } from '../../../redux/actions/accountAction';
 
@@ -66,11 +67,12 @@ const AccountsBottomSheetContainer = () => {
     }
   };
 
-  const _navigateToRoute = (name: string, params: any) => {
+  const _navigateToRoute = <K extends RouteName>(...[name, params]: NavigateArgs<K>) => {
     SheetManager.hide(SheetNames.ACCOUNTS_SHEET);
     accountsBottomSheetViewRef.current?.closeAccountsBottomSheet();
     if (name) {
-      RootNavigation.navigate({ name, params });
+      // Correlated by the generic at the call site; TS cannot re-derive that pairing here.
+      RootNavigation.navigate({ name, params } as NavigateOptions);
     }
   };
 

src/components/accountsBottomSheet/view/accountsBottomSheetView.tsx

@@ -15,6 +15,7 @@ import HiveAuthIconSource from '../../../assets/HiveAuth_logo.png';
 import HiveIconSource from '../../../assets/hive_icon.png';
 
 import { default as ROUTES } from '../../../constants/routeNames';
+import { NavigateArgs, RouteName } from '../../../navigation/types';
 
 import styles from './accountsBottomSheetStyles';
 
@@ -26,7 +27,7 @@ export interface AccountsBottomSheetRef {
 export interface AccountsBottomSheetProps {
   accounts: any[];
   currentAccount: any;
-  navigateToRoute: (route: string, params?: any) => void;
+  navigateToRoute: <K extends RouteName>(...args: NavigateArgs<K>) => void;
   switchAccount: (account: any) => void;
   prevLoggedInUsers: Array<any>;
   dispatch: (action: any) => void;

src/components/aiAssistModal/aiAssistModal.tsx

@@ -52,7 +52,8 @@ export const AiAssistModal = ({ payload }: SheetProps<SheetNames.AI_ASSIST>) =>
   const [result, setResult] = useState<{ output: string; action: AiAssistAction } | null>(null);
   const [selectedTitleIndex, setSelectedTitleIndex] = useState(0);
 
-  // Reset state when payload changes (sheets stay mounted)
+  // Sheets mount on show, so this seeds the input on every open. The `payload` dep additionally
+  // covers a re-show onto a still-mounted sheet.
   useEffect(() => {
     const newText = payload?.text?.slice(0, MAX_INPUT) || '';
     setText(newText);

src/components/balanceAnalyticsSheet/balanceAnalyticsSheet.tsx

@@ -83,10 +83,9 @@ const BalanceAnalyticsSheet = ({ payload }: SheetProps<SheetNames.BALANCE_ANALYT
   const [activeTab, setActiveTab] = useState<Tab>('history');
   const [granularity, setGranularity] = useState<Granularity>('yearly');
 
-  // Action sheets stay mounted between presentations (per CLAUDE.md
-  // sheet-pattern note), so reset our local view state whenever the sheet is
-  // re-opened with a new payload — otherwise the previous account/coin's tab
-  // and granularity selection leak into the new view.
+  // Sheets mount on show, so useState already seeds these on a normal open. This effect covers
+  // a re-show onto a still-mounted sheet with a different account/coin, whose tab and
+  // granularity selection would otherwise leak into the new view.
   useEffect(() => {
     setActiveTab('history');
     setGranularity('yearly');

src/components/communityRoleEditSheet/communityRoleEditSheet.tsx

@@ -94,9 +94,9 @@ const CommunityRoleEditSheet: React.FC<SheetProps<'community_role_edit'>> = ({
     setError('');
   }, [payload?.account]);
 
-  // Registered sheets stay mounted, and resetting on payload identity alone is
-  // not enough when the same payload object is reused, so reset on every
-  // presentation.
+  // Sheets mount on show, so mounting is what guarantees the reset on every presentation. The
+  // `payload` dep only covers a re-show onto a still-mounted sheet, and it cannot be relied on
+  // alone: a caller reusing the same payload object would not re-fire it.
   useEffect(() => {
     _reset();
   }, [payload, _reset]);

src/components/composeTranslateModal/composeTranslateModal.tsx

@@ -56,9 +56,16 @@ export const ComposeTranslateModal = ({ payload }: SheetProps<SheetNames.COMPOSE
   const [progress, setProgress] = useState<[number, number]>([0, 0]);
   const [failed, setFailed] = useState(false);
 
-  // Sheets stay mounted; a closed sheet cancels the request chain so it stops
-  // hitting the translation service in the background.
-  const closedRef = useRef(false);
+  // Identifies the current translation run. A run is superseded by closing the sheet, by
+  // unmount, by a re-show carrying a new payload, by changing the language pair, and by
+  // starting another translation. translateMarkdown pages the service request by request and
+  // only consults its cancel callback between pages, so a run always has to be assumed still
+  // in flight: everything it writes back is gated on still being the current run.
+  //
+  // A plain "closed" flag was not enough. It was cleared again on re-show, and the result
+  // handler did not consult it at all, so a run that resolved after the user switched target
+  // language applied its result to the new pair, defeating the reset below.
+  const runIdRef = useRef(0);
 
   const sample = useMemo(
     () =>
@@ -72,10 +79,19 @@ export const ComposeTranslateModal = ({ payload }: SheetProps<SheetNames.COMPOSE
   );
   const tooShort = sample.trim().length < MIN_TRANSLATE_CHARS;
 
-  // Reset state and re-detect the source language on every open (payload is a
-  // fresh object per SheetManager.show).
+  // Sheets unmount on hide, so the run has to be retired here as well: onClose is not
+  // guaranteed to be the route the sheet leaves by, and a run left current keeps paging the
+  // translation service for a screen the user has already dismissed.
+  useEffect(
+    () => () => {
+      runIdRef.current += 1;
+    },
+    [],
+  );
+
+  // Sheets mount on show, so this resets state and re-detects the source language on every open.
   useEffect(() => {
-    closedRef.current = false;
+    runIdRef.current += 1;
     setTranslated('');
     setFailed(false);
     setTranslating(false);
@@ -111,8 +127,16 @@ export const ComposeTranslateModal = ({ payload }: SheetProps<SheetNames.COMPOSE
     setTarget(reader && reader !== 'en' && LIBRETRANSLATE_TARGETS.has(reader) ? reader : 'es');
   }, [source, appLang]);
 
-  // A result translated into a previous language pair must never be applied.
+  // A result translated into a previous language pair must never be applied. Retiring the run
+  // is what enforces that: clearing the state alone loses the race against a run still in
+  // flight, which would write its result back a moment later.
+  //
+  // Clearing `translating` is part of retiring it. The run being cancelled can no longer do it
+  // itself, because every write it makes is now gated on still being current, and a stuck
+  // `translating` leaves the spinner up with both action buttons disabled.
   useEffect(() => {
+    runIdRef.current += 1;
+    setTranslating(false);
     setTranslated('');
     setFailed(false);
   }, [source, target]);
@@ -131,6 +155,10 @@ export const ComposeTranslateModal = ({ payload }: SheetProps<SheetNames.COMPOSE
   );
 
   const _translate = async () => {
+    runIdRef.current += 1;
+    const runId = runIdRef.current;
+    const isCurrent = () => runIdRef.current === runId;
+
     setTranslating(true);
     setFailed(false);
     setTranslated('');
@@ -140,17 +168,23 @@ export const ComposeTranslateModal = ({ payload }: SheetProps<SheetNames.COMPOSE
         body,
         source,
         target,
-        (done, total) => setProgress([done, total]),
-        () => closedRef.current,
+        (done, total) => {
+          if (isCurrent()) {
+            setProgress([done, total]);
+          }
+        },
+        () => !isCurrent(),
       );
-      setTranslated(result);
+      if (isCurrent()) {
+        setTranslated(result);
+      }
     } catch (error) {
       console.log('translate error : ', error);
-      if (!closedRef.current) {
+      if (isCurrent()) {
         setFailed(true);
       }
     } finally {
-      if (!closedRef.current) {
+      if (isCurrent()) {
         setTranslating(false);
       }
     }
@@ -173,7 +207,7 @@ export const ComposeTranslateModal = ({ payload }: SheetProps<SheetNames.COMPOSE
   };
 
   const _handleOnSheetClose = () => {
-    closedRef.current = true;
+    runIdRef.current += 1;
     setTranslating(false);
   };
 

src/components/foregroundNotification/foregroundNotification.tsx

@@ -128,31 +128,23 @@ const ForegroundNotification = ({ remoteMessage }: Props) => {
     const { data } = remoteMessage;
     const { type } = data;
 
-    let routeName;
-    let params;
-    let key;
-
     if (type === 'transfer' || type === 'delegations') {
       // Navigate to wallet for financial transactions
-      routeName = ROUTES.TABBAR.WALLET;
+      RootNavigation.navigate({ name: ROUTES.TABBAR.WALLET });
     } else {
       // Navigate to post for reply/mention
       const fullPermlink =
         get(data, 'permlink1', '') + get(data, 'permlink2', '') + get(data, 'permlink3', '');
 
-      params = {
-        author: get(data, 'source', ''),
-        permlink: fullPermlink,
-      };
-      key = fullPermlink;
-      routeName = ROUTES.SCREENS.POST;
+      RootNavigation.navigate({
+        name: ROUTES.SCREENS.POST,
+        params: {
+          author: get(data, 'source', ''),
+          permlink: fullPermlink,
+        },
+        key: fullPermlink,
+      });
     }
-
-    RootNavigation.navigate({
-      name: routeName,
-      params,
-      key,
-    });
     hide();
   };
 

src/components/iconButton/view/iconButtonView.tsx

@@ -1,5 +1,12 @@
 import React, { Fragment } from 'react';
-import { TouchableOpacity, ActivityIndicator, StyleProp, TextStyle, ViewStyle } from 'react-native';
+import {
+  TouchableOpacity,
+  TouchableOpacityProps,
+  ActivityIndicator,
+  StyleProp,
+  TextStyle,
+  ViewStyle,
+} from 'react-native';
 import EStyleSheet from 'react-native-extended-stylesheet';
 import { Icon } from '../../icon';
 
@@ -23,6 +30,9 @@ interface IconButtonProps {
   isLoading?: boolean;
   iconStyle?: StyleProp<TextStyle>;
   style?: StyleProp<ViewStyle>;
+  // The button is a fixed 30x30, below the 44pt guideline. Opt in per call site where a
+  // mis-tap is costly, rather than changing the hit area of every icon button at once.
+  hitSlop?: TouchableOpacityProps['hitSlop'];
   onPress?: (event?: any) => void;
   onLongPress?: (event?: any) => void;
   accessibilityLabel?: string;
@@ -46,10 +56,12 @@ const IconButton = ({
   isLoading,
   accessibilityLabel,
   accessibilityHint,
+  hitSlop,
 }: IconButtonProps) => (
   <Fragment>
     <TouchableOpacity
       style={[styles.iconButton, style]}
+      hitSlop={hitSlop}
       onPress={() => !isLoading && onPress && onPress()}
       disabled={disabled}
       onLongPress={() => !isLoading && onLongPress && onLongPress()}

src/components/post-translation-modal/postTranslationModal.tsx

@@ -47,11 +47,9 @@ const PostTranslationModal = ({ payload }: SheetProps<'post_translation'>) => {
     getSupportedLanguages();
   }, []);
 
-  // Sheets stay mounted and _handleOnSheetClose resets the target on close, so
-  // re-apply the pre-selected target/source on EVERY open. Keying on `payload`
-  // (a fresh object per SheetManager.show) is what makes this re-fire when the
-  // sheet is reopened from the same chip/banner with unchanged initial codes —
-  // without it the pre-targeting would only work once per session.
+  // Sheets mount on show, so this applies the pre-selected target/source on every open. It has
+  // to run again once the language list resolves, which is why the list is a dependency: on the
+  // first open the codes arrive before the list and there is nothing to match them against yet.
   useEffect(() => {
     if (!supportedLangsList.length) {
       return;

src/components/postElements/body/view/commentBodyView.tsx

@@ -73,13 +73,11 @@ const CommentBody = ({
         return;
       }
       const name = isCommunity(tag) ? ROUTES.SCREENS.COMMUNITY : ROUTES.SCREENS.TAG_RESULT;
-      const key = `${filter}/${tag}`;
       RootNavigation.navigate({
         name,
         params: {
           tag,
           filter,
-          key,
         },
       });
     }