Skip to content

Commit 99f426e

Browse files
committed
Move some 1.9.20.1 bug tests to correct directory
Signed-off-by: Alexander Kriegisch <[email protected]>
1 parent 39c5da6 commit 99f426e

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

tests/src/test/java/org/aspectj/systemtest/ajc1920/Bugs1920Tests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ public void test_GitHub_250() {
7070
/**
7171
* If one generic method overrides another one with a narrower return type, avoid matching bridge methods.
7272
* <p>
73-
* See <a href="https://github.com/spring-projects/spring-framework/issues/27761">Spring GitHub issue 27761</a>.
73+
* See <a href="https://github.com/spring-projects/spring-framework/issues/27761">Spring GitHub issue 27761</a>,
74+
* <a href="https://github.com/eclipse-aspectj/aspectj/issues/257">AspectJ GitHub issue 257</a>.
7475
* <p>
7576
* This test uses an ASM-modified class file reproducing the problem seen in Spring in plain AspectJ. Before the
7677
* bugfix, it fails with <b>"advice defined in RepositoryAspect has not been applied [Xlint:adviceDidNotMatch]".</b>

tests/src/test/resources/org/aspectj/systemtest/ajc1920/ajc1920.xml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -418,8 +418,11 @@
418418
</run>
419419
</ajc-test>
420420

421-
<!-- https://github.com/spring-projects/spring-framework/issues/27761 -->
422-
<ajc-test dir="bugs1921/gh_spring_27761" vm="8" title="do not match bridge methods">
421+
<!--
422+
https://github.com/spring-projects/spring-framework/issues/27761, AspectJ 1.9.20.1
423+
https://github.com/eclipse-aspectj/aspectj/issues/257
424+
-->
425+
<ajc-test dir="bugs1920/github_spring_27761" vm="8" title="do not match bridge methods">
423426
<!-- (1) Use ASM to generate JpaRepository class with reordered methods -->
424427
<compile files="JpaRepositoryDump.java" options="-8"/>
425428
<run class="JpaRepositoryDump" options="$sandbox"/>
@@ -434,8 +437,8 @@
434437
</run>
435438
</ajc-test>
436439

437-
<!-- https://github.com/eclipse-aspectj/aspectj/issues/257 -->
438-
<ajc-test dir="bugs1921/gh_257" vm="8" title="handle negated type patterns correctly">
440+
<!-- https://github.com/eclipse-aspectj/aspectj/issues/257, AspectJ 1.9.20.1 -->
441+
<ajc-test dir="bugs1920/github_257" vm="8" title="handle negated type patterns correctly">
439442
<compile files="NegatedTypeAspect.aj" options="-8"/>
440443
<run class="NegatedTypeAspect">
441444
<stdout>

0 commit comments

Comments
 (0)